\Drupal calls should be avoided in classes, use dependency injection instead in src/EventSubscriber/RedirectRequestSubscriber.php

I did find only this little error in #5

+++ b/src/EventSubscriber/RedirectRequestSubscriber.php
@@ -148,7 +159,7 @@ class RedirectRequestSubscriber implements EventSubscriberInterface {
+      $this->logger('redirect')->warning('Redirect loop identified at %path for redirect %rid', ['%path' => $e->getPath(), '%rid' => $e->getRedirectId()]);

Follow a new patch.

Follow a patch that also changes the test

@thalles Hello,

The provided patch is working fine. Thanks for your contribution.

1. +++ b/src/EventSubscriber/RedirectRequestSubscriber.php
   @@ -73,6 +74,13 @@ class RedirectRequestSubscriber implements EventSubscriberInterface {
    
   +  /**
   +   * The logger service.
   +   *
   +   * @var \Drupal\Core\Logger\LoggerChannelFactoryInterface
   +   */
   +  protected $logger;
   +
   

   Lets name this loggerFactory and similar for the description.

2. +++ b/src/EventSubscriber/RedirectRequestSubscriber.php
   @@ -92,8 +100,10 @@ class RedirectRequestSubscriber implements EventSubscriberInterface {
       *   Request context.
   +   * @param \Drupal\Core\Logger\LoggerChannelFactoryInterface $logger
   +   *   The logger service.
       */
   -  public function __construct(RedirectRepository $redirect_repository, LanguageManagerInterface $language_manager, ConfigFactoryInterface $config, AliasManagerInterface $alias_manager, ModuleHandlerInterface $module_handler, EntityTypeManagerInterface $entity_type_manager, RedirectChecker $checker, RequestContext $context, InboundPathProcessorInterface $path_processor) {
   +  public function __construct(RedirectRepository $redirect_repository, LanguageManagerInterface $language_manager, ConfigFactoryInterface $config, AliasManagerInterface $alias_manager, ModuleHandlerInterface $module_handler, EntityTypeManagerInterface $entity_type_manager, RedirectChecker $checker, RequestContext $context, InboundPathProcessorInterface $path_processor, LoggerChannelFactoryInterface $logger) {
        $this->redirectRepository = $redirect_repository;
        $this->languageManager = $language_manager;
        $this->config = $config->get('redirect.settings');
   @@ -103,6 +113,7 @@ class RedirectRequestSubscriber implements EventSubscriberInterface {
   
   @@ -103,6 +113,7 @@ class RedirectRequestSubscriber implements EventSubscriberInterface {
        $this->checker = $checker;
        $this->context = $context;
        $this->pathProcessor = $path_processor;
   +    $this->logger = $logger;
      }
   

   Lets make the new argument optional with a fallback to \Drupal::service(), for people that forget to clear caches or use the UI to do so.

Follow a new patch

above patch is not applying.

Looks good to me!

patch #16 works for me

+++ b/src/EventSubscriber/RedirectRequestSubscriber.php
@@ -19,13 +19,15 @@ use Symfony\Component\HttpKernel\KernelEvents;
 class RedirectRequestSubscriber implements EventSubscriberInterface {
 
-  /** @var  \Drupal\redirect\RedirectRepository */
+  /**
+   * @var  \Drupal\redirect\RedirectRepository*/
   protected $redirectRepository;
 

This is still invalid. either don't touch it or then change it to be correct :)

See also this duplicate issue #3014858: Use dependency injection for redirect classes

Closing this issue as duplicated from #3014858: Use dependency injection for redirect classes