Remove unused variables [#3112419]

Comment	File	Size	Author
#10	3112419-remove-unused-variable.patch	1.96 KB	garvitasakhrani
#8	interdiff-2-8.txt	548 bytes	hardik_patel_12
#8	3112419-8.patch	761 bytes	hardik_patel_12
#5	Screenshot 2020-02-12 at 1.38.54 PM.png	385.01 KB	Rangaswini
#5	Screenshot 2020-02-12 at 1.38.57 PM.png	304.53 KB	Rangaswini
#5	Screenshot 2020-02-12 at 1.37.52 PM.png	121.96 KB	Rangaswini
#2	3112419-2.patch	1.42 KB	hardik_patel_12

Issue fork redirect-3112419

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3112419-remove-unused-variables changes, plain diff MR !195
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

10 February 2020 at 11:45

Hardik_Patel_12 created an issue. See original summary.

Comment #2

hardik_patel_12 commented 10 February 2020 at 11:46

Status	File	Size
new	3112419-2.patch	1.42 KB

Kindly review a patch.

Comment #3

hardik_patel_12 commented 10 February 2020 at 11:47

Assigned:	hardik_patel_12	» Unassigned
Status:	Needs work	» Needs review

Comment #4

Rangaswini commented 12 February 2020 at 07:02

Assigned:

Unassigned

» Rangaswini

Comment #5

Rangaswini commented 12 February 2020 at 08:22

Issue summary:

View changes

Status	File	Size
new	Screenshot 2020-02-12 at 1.37.52 PM.png	121.96 KB
new	Screenshot 2020-02-12 at 1.38.57 PM.png	304.53 KB
new	Screenshot 2020-02-12 at 1.38.54 PM.png	385.01 KB

Thank you @Hardik_Patel_12 for the patch. I have reviewed the above patch. LGTM

Comment #6

Rangaswini commented 12 February 2020 at 08:56

Assigned:	Rangaswini	» Unassigned
Issue summary:	View changes
Status:	Needs review	» Reviewed & tested by the community

Comment #7

berdir

German

Switzerland

commented 12 May 2020 at 18:46

Status:

Reviewed & tested by the community

» Needs work

Sorry for the slow response, doesn't apply anymore.

Comment #8

hardik_patel_12 commented 17 June 2020 at 06:54

Status:

Needs work

» Needs review

Status	File	Size
new	3112419-8.patch	761 bytes
new	interdiff-2-8.txt	548 bytes

4 files were hidden/shown/deleted

Status	File	Size
hidden	3112419-2.patch	1.42 KB
hidden	Screenshot 2020-02-12 at 1.37.52 PM.png	121.96 KB
hidden	Screenshot 2020-02-12 at 1.38.57 PM.png	304.53 KB
hidden	Screenshot 2020-02-12 at 1.38.54 PM.png	385.01 KB

Yes ,

 $message = new FormattableMarkup('Testing redirect from %from to %to. Ending url: %url', [
      '%from' => $path,
      '%to' => $expected_ending_url,
      '%url' => $ending_url,
    ]);

is removed from GlobalRedirectTest.php test files , but we can remove $storage_definition unused variable from install file.

Kindly review a new patch.