Problem/Motivation

Theme functions have been deprecated in #2576881: Deprecate theme functions for removal before Drupal 9 (docs only). However, use of theme functions cannot be identified with the current checks.

Proposed resolution

Add detection for use of theme functions.

Remaining tasks

CommentFileSizeAuthor
#10 interdiff.txt1.25 KBgábor hojtsy
#10 3111022-10.patch19.04 KBgábor hojtsy
#7 interdiff.txt6.13 KBgábor hojtsy
#7 3111022-7.patch19.03 KBgábor hojtsy
#6 interdiff.txt761 byteslauriii
#6 3111022-6.patch18.82 KBlauriii
#4 3111022-4.patch18.08 KBlauriii

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Related issues: +#2576881: Deprecate theme functions for removal before Drupal 9 (docs only), +#3109480: Properly deprecate theme functions for Drupal 10, +#3097889: Remove deprecated theme functions
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Assigned: Unassigned » lauriii
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Assigned: lauriii » Unassigned
Status: Active » Needs review
StatusFileSize
new 3111022-4.patch18.08 KB

Status: Needs review » Needs work

The last submitted patch, 4: 3111022-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs work » Needs review
StatusFileSize
new 3111022-6.patch18.82 KB
new interdiff.txt761 bytes
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new 3111022-7.patch19.03 KB
new interdiff.txt6.13 KB

Looked good other than a few code comment things. While fixing those, I decided to log the parse error as well, since we do that for other errors that stopped us from analysing so people are aware that there may be an issue there, but we could not tell.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

+1 to all changes! 👍

Status: Needs review » Needs work

The last submitted patch, 7: 3111022-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Needs review
StatusFileSize
new 3111022-10.patch19.04 KB
new interdiff.txt1.25 KB

Fix tests to the changed message.

  • Gábor Hojtsy committed 343ccdf on 8.x-2.x 
    Issue #3111022 by Gábor Hojtsy, lauriii: Detect use of theme functions
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Yay, committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.