Remove deprecated theme functions

I have reviewed the patch #9 and it's working as we expected in the 9.0.x version. Most of the deprecated theme functions have been removed. Please refer to the attached screens.

+++ b/core/includes/theme.inc
@@ -122,65 +122,6 @@ function drupal_theme_rebuild() {
-/**
- * Allows themes and/or theme engines to discover overridden theme functions.
- *
- * @param array $cache
- *   The existing cache of theme hooks to test against.
- * @param array $prefixes
- *   An array of prefixes to test, in reverse order of importance.
- *
- * @return array
- *   The functions found, suitable for returning from hook_theme;
- */
-function drupal_find_theme_functions($cache, $prefixes) {

I hate to say this but … it looks like this wasn't deprecated? 🤔

I think this needs review from a theme subsystem maintainer.

It seems like theme functions are still being used by contrib projects: http://grep.xnddx.ru/search?text=function%20theme_&filename=. 😳 Based on this, it seems risky to remove theme functions without first triggering proper deprecation errors. 😩 In my opinion, we should schedule the removal to Drupal 10. 😭

#14 is exactly what I feared, but wanted a theme system maintainer to give their more informed stance. Unfortunate. But pragmatic.

So I guess the next step is to create that followup now, get modern deprecation messages committed to 9.1.x for removal in 10.x, and then postpone this issue until 10.x?

These seem like the correct next steps to me. Adding a tag for creating the follow-up to try to ensure that the follow-up gets filed this time 😅

Awesome, thank you @longwave!

It's not a part of meta anymore

Rerolled for 9.2.x, as patch #9 doesn't apply for the same

Adding the proper parent.

I'm working on a re-row.

Only a re-row for now.

Per @catch at #3244802-8: Remove BC layers in entity system, any deprecation removal issue should be on hold until after 10.0.0-alpha1 is tagged.

Thanks!
-Derek

right parent is #3213895: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 10 branch

Faced in #3260778-5: Remove deprecated code from bootstrap.inc more work needed for issue to remove @todo to it

Ironically, this might break upgrade_status...

http://grep.xnddx.ru/search?text=drupal_find_theme_functions&filename=

I think we need a 9.4.x follow-up to deprecate (or mark internal?) drupal_find_theme_functions() for removal in Drupal 10. But since upgrade_status is the only usage in contrib and custom use seems extremely unlikely, seems OK to go ahead here.

Upgrade status could use follow-up to and drupal_find_theme_functions() ++ as well

Opened the follow-up for drupal_find_theme_functions() #3262500: Mark drupal_find_theme_functions() @internal in Drupal 9 in 9.4.x

I was about to open the follow-up for Upgrade Status, but the 8.3.x branch doesn't have this usage, only the 8.2.x branch, so it's actually fine.

This reminds me Upgrade Status is not even Drupal 10 alpha1 compatible (facepalm). Either way, compatibility with versions later than alpha1 is not intended until it would check for Drupal 11 compatibility :D Opened #3262488: Make Upgrade Status compatible with Drupal 10 in Upgrade Status.

That said, Upgrade Status may be able to just include a copy of this global function I think? The underlying getPrefixGroupedUserFunctions() did not seem to have been modified? Actually, I think we should just make that check optional. Opened #3262503: Don't attempt to use drupal_find_theme_functions() on Drupal 10 in Upgrade Status.

@catch: 8.x-3.x of Upgrade Status also uses drupal_find_theme_functions() in ThemeFunctionDeprecationAnalyzer, so it is definitely still there. So I think #3262503: Don't attempt to use drupal_find_theme_functions() on Drupal 10 is valid to fix then.

@Gábor Hojtsy ahh thanks, maybe http://grep.xnddx.ru just doesn't have the 3.x branch yet, glad I opened the issue after all.

Committed/pushed to 10.0.x, thanks!

Very glad we don't have to keep this around for another release.

Thank you! re-titled #3262500: Mark drupal_find_theme_functions() @internal in Drupal 9 as follow-up