Postponed on #3257837: Use or ignore-requirement-for PHP 8 in Drupal 10 lockfile generation.

Problem/Motivation

Based on reasoning in #3118143-32: [meta] Release Drupal 10 on December 14... or 15... 2022, I think we should try to tag an 'early alpha' snapshot, with as many dependencies updated as possible (Symfony 5.4 with as many deprecations addressed as possible , not 6.0), so that there is a target to test contrib against.

Once we've done that we, can then start on deprecation removals and updating to Symfony 6 - which can then lead onto later alphas and betas.

Note that while we should try to update as many dependencies as possible, if we have most things updated and one or two tricky ones not, there's still benefit to releasing an alpha1, then following up with alpha2 later on.

Proposed resolution

  1. DONE: #3252088: Increase Drupal::MINIMUM_PHP to 8.0.0
  2. DONE: Increase PostgreSQL required version to 12 and require pg_trim (currently only a warning in D9) (reference: #3190635: [policy] Require PostgreSQL 12 with pg_trgm for Drupal 10 (raise from v10 in Drupal 9))
  3. DONE: Require json1 extension for SQLite (reference: #3190641: [policy] Require SQLite 3.26 for Drupal 10 (same as Drupal 9) with the json1 extension required (new requirement for Drupal 10))
  4. Symfony 5.4
     
    1. MUST HAVES DONE: First resolve API deprecations that can only be done on Drupal 10, so our state is as compatible with Symfony 6 while still being compatible with Symfony 5.4 as possible. #3161889: [META] Symfony 6 compatibility
    2. DONE: Then do the actual update to Symfony 5.4 #3197482: Update Drupal 10 to depend on Symfony 5.4 (as a stepping stone to Symfony 6, for deprecation checking support)
  5. DONE: Twig 3 #3094493: Upgrade to Twig 3
  6. DONE: Guzzle 7 #3104353: Upgrade to Guzzle 7
  7. DONE: Guzzle psr/7
    1. #3220220: Update guzzlehttp/psr7 to 2.1.0
    2. #3255243: Replace Diactoros' PSR-17 implementation with Guzzle's
  8. DONE: Remove Diactoros #3039047: Adopt php-http/guzzle6-adapter 2.x to get PSR-18 support without losing Guzzle's async support

Optional (pre-alpha targets)

  1. #3250585: Highlight deprecated modules and themes at admin/reports/status page, providing warning and link with explanation
  2. #3252084: [meta] Remove support for Internet Explorer
  3. #3213895: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 10 branch

Any more?

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes

Updating the list in the summary to be a list :)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Requirements for tagging Drupal 10.0.0-alpha1 » [META] Requirements for tagging Drupal 10.0.0-alpha1
Category: Task » Plan

Also meta-ifying.

mondrake’s picture

mondrake
Location 🇮🇹
commented

Filed #3252010: Lock PHPUnit to 9.5

andypost’s picture

andypost
he/him
Primary language Russian
commented

asm89/stack-cors needs upgrade to 2.0 because of https://github.com/asm89/stack-cors/issues/64

added as child #3128982: Upgrade asm89/stack-cors to ^2.0 to fix cacheability

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes

Update Symfony 5.4 plan to make the role of the two issues clearer.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes

@catch and I agreed to allow the commit of #3253148: Remove IE from core's browserlist, remove non-essential CSS importing and recompile assets as well since browser requirements are similar to platform requirements.

We're missing the issues to bump the platform requirements, also. To my knowledge, the only two are bumping the PostgreSQL required version to 12, and increasing the required PHP version to 8.0?

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes

Oops #3252088: Increase Drupal::MINIMUM_PHP to 8.0.0 already landed, just wasn't in the IS.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes

Broke out Guzzle PSR-17 to two issues as per @xjm's recommendation.

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented

there is set of Symfony packages, not following the regular versioning (copy paster from #3255245-9: [Symfony 6] Revert 3231603 to use our own TranslatorInterface)

❯ composer info "symfony/*" | grep contracts
symfony/cache-contracts            v2.5.0  Generic abstractions related to caching
symfony/deprecation-contracts      v2.5.0  A generic function and convention to trigger deprecation notices
symfony/event-dispatcher-contracts v1.1.11 Generic abstractions related to dispatching event
symfony/http-client-contracts      v2.5.0  Generic abstractions related to HTTP clients
symfony/service-contracts          v2.5.0  Generic abstractions related to writing services
symfony/translation-contracts      v2.5.0  Generic abstractions related to translation

Should not those be updated to v3 as well ?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

We can't update all of these yet, e.g. translation-contracts 3 requires Symfony 6:

$ composer why-not symfony/translation-contracts 3
symfony/string                 v5.4.0  conflicts  symfony/translation-contracts (>=3.0)  
symfony/translation            v5.4.1  requires   symfony/translation-contracts (^2.3)   
symfony/translation-contracts  v3.0.0  requires   php (>=8.0.2 but 8.0.0 is installed)

We do have a good reason to bump to a minimum of PHP 8.0.2 though:

$ composer why-not symfony/event-dispatcher-contracts 3
symfony/event-dispatcher-contracts  v3.0.0  requires  php (>=8.0.2 but 8.0.0 is installed)
catch’s picture

catch
he/him
Primary language English
commented

#3255271: Increase Drupal::MINIMUM_PHP to 8.0.2 is ready to land (again) when DrupalCI is.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

Thoughts on adding #3219958: [META] Make Olivero the default theme to the requirement?

We're stable, and have a our tests passing on #3219959: Update standard profile so Olivero is the default theme (although we need to rebase the branch into10.0.x)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

@mherchel: the first alpha is meant to be a technical step mainly for updating the major dependencies, especially Symfony. There will be various further alpha releases and beta releases. There is nothing wrong with aiming to have it the default in the alpha release, but to hold the alpha for Olivero not being the default is not in line with the scope of the first alpha.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

Sounds good!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Discussed the idea of not removing deprecated code until after the first alpha with @catch. I think there are a couple of reasons that we should remove code immediately. These are:

catch’s picture

catch
he/him
Primary language English
commented

So the idea here has been to release '9.4 + dependency updates'. We've nearly done everything in the issue summary now, down to Twig 3 and one Symfony 5.4 issue. That would allow us to tag alpha1 this month.

If we make removing Drupal deprecations a requirement for alpha1, then we're looking at an extra few weeks/months, and because we're still deprecating things in 9.4, it won't be a complete list so will be hard to define exactly what it means. We could decide to just start committing as many deprecation removals as we can, without making it an alpha1 blocker, but that might take as long to decide as tagging the alpha and beginning deprecation removals.

I think contrib will get some benefit from having Symfony 5/Twig 3/Guzzle 7 etc. without Drupal deprecations, but even if they don't, it's cost us a tag rather than actual time and we can continue to release new alphas including with Drupal deprecations removed as we go.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes

Of the two current showstoppers here #3094493: Upgrade to Twig 3 needs a reroll, but otherwise is ready. The translation one needs more discussion, but with a bit of focus I hope we can solve it one way or another? At worst we can defer the deprecation notice. So it does not seem like we are too far away from alpha1 and indeed it would be great to have a way to reliably test Drupal 9 projects against Drupal 10 + SF5 given the SF4 to SF6 jump otherwise.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

I don't think we should make deprecation removal a requirement - but I don't think we should hold up removing anything that is ready. The more deprecated code that is removed by the time alpha 1 is released the better it is for contrib testing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes

All must haves on #3161889: [META] Symfony 6 compatibility are now done. The only remaining must have on this issue is #3197482: Update Drupal 10 to depend on Symfony 5.4 (as a stepping stone to Symfony 6, for deprecation checking support) for the alpha, and that is RTBC. #holdingbreath

Updating issue summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue summary: View changes

#3197482: Update Drupal 10 to depend on Symfony 5.4 (as a stepping stone to Symfony 6, for deprecation checking support) landed, so all requirements are met.

catch’s picture

catch
he/him
Primary language English
commented

We should do a final round of dependency updates before actually tagging, e.g. #3255353: Update dependencies for Drupal 10.0.x before alpha1.

I'd love to get #3250585: Highlight deprecated modules and themes at admin/reports/status page, providing warning and link with explanation in too if we can, although it shouldn't block.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes

All alpha requirements are now done. We are working on the release notes. In the meantime, adding #3250585: Highlight deprecated modules and themes at admin/reports/status page, providing warning and link with explanation as per @catch since that would be a really nice to have in alpha1.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
Related issues: +#3213895: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 10 branch

I think deprecation removal could go before alpha because there's 9.4 branch to run linters/sniffers and fix custom/contrib codebases

Added to IS #3213895: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 10 branch

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: [META] Requirements for tagging Drupal 10.0.0-alpha1 » [PP-1] [META] Requirements for tagging Drupal 10.0.0-alpha1
Issue summary: View changes

#3257837: Use or ignore-requirement-for PHP 8 in Drupal 10 lockfile generation is the only thing that needs resolving prior to alpha as far as I know.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: [PP-1] [META] Requirements for tagging Drupal 10.0.0-alpha1 » [META] Requirements for tagging Drupal 10.0.0-alpha1
Status: Active » Fixed

Alpha1 is now available at https://www.drupal.org/project/drupal/releases/10.0.0-alpha1

See you all in #3118149: [meta] Requirements for tagging Drupal 10.0.0-beta1.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
commented

Belatedly saving credits for those who helped maintain this plan.