Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
When this module is used in conjunction with the media_entity_twitter module, pages that contain such media entities cannot be shared on twitter.
Steps to reproduce:
- Install and enable this module as well as the media_entity_twitter module
- Create a new media entity with the twitter provider
- Add a new field to a content type, that references to twitter media
- Create a new node which contains a tweet
- Make sure that the media entity, and the shariff twitter button are displayed correctly on the new node
Clicking on the Shariff twitter button on that newly created page will not have any effect.
Proposed resolution
A few years ago the Shariff library opened the twitter sharing overlay twice. For this a workaround was added to this module, that prevented propagating events (see #2881126 and #2845000).
This is making problems now. And since that workaround is not necessary anymore, we can get rid of that whole javascript file.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3108089-4.patch | 4.96 KB | dejan0 |
| #2 | 3108089_2.patch | 2.36 KB | daniel.bosen |
Comments
Comment #2
daniel.bosenThe patch removes
js/shariff.jsComment #3
daniel.bosenComment #4
dejan0 commentedPatch from daniel.bosen works fine.
Here is an updated version, it's good to have updated minimum required version of Shariff Library to v2.0.1
Comment #5
daniel.bosen@dejan0 I would rather keep seperate issues in seperate patches, makes live for reviewing much easier.
Comment #6
criz@daniel.bosen
I am not 100% sure, but I think its related, as there has been added a fix for the twitter issue in the 1.26 release of the shariff library: https://github.com/heiseonline/shariff/releases/tag/1.26.0
So having an updated minimum requirement is good to have.
Comment #7
crizComment #8
daniel.bosentrue story :-)
Comment #10
crizThanks!
Comment #12
pivica commentedThis patch is fixing an issue we had (same thing twitter button with twitter widget and no popup opening). After applying this patch problem is fixed but behavior is different. However on clicking a twitter button share page is now opened in a new browser tab instead of a new popup browser window. Probably something that is hard to fix because this is controlled by twitter widget JS code, just reporting it here for now.