Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.While investigating the twitter popup issue in Firefox ESR, we noticed that the js file wasn't commited from the provided patch in https://www.drupal.org/node/2845000. See http://cgit.drupalcode.org/shariff/commit/?id=8f1504316fc7f8fbd525282518...
Also, there is the dependency to jquery.once missing, which is responsible for our error in Firefox ESR.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | two_twitter_popups-2881126-6-interdiff.txt | 821 bytes | berdir |
| #6 | two_twitter_popups-2881126-6.patch | 1.44 KB | berdir |
| #5 | two_twitter_popups-2881126-5-interdiff.txt | 818 bytes | berdir |
| #5 | two_twitter_popups-2881126-5.patch | 1.44 KB | berdir |
| #2 | two_twitter_popups-2881126-2.patch | 1.23 KB | tjwelde |
Comments
Comment #2
tjwelde commentedThis patch fixes both issues.
Comment #3
tjwelde commentedI also think, the shariff_library_info_alter hook can be removed, since it has no purpose here anymore.
Comment #4
mtodor commentedI have tested this - and it works.
Hook "shariff_library_info_alter" is still needed, because of different deployment directories in case of composer workflow.
Comment #5
berdirThis is missing the dependency on core/drupal because I get this as anonymous user when nothing else loads that on the page:
Uncaught ReferenceError: Drupal is not defined
Comment #6
berdirAnd now with 100% less stupid typos ;)
Comment #8
crizThanks, a pity that this js files has been overseen in committing #2845000: Two twitter pop-up windows appear on page with twitter integration.