Fix the issues reported by phpcs

Attaching a patch which fixes most of these issues (not all).

Also applied TokenTestTrait assertTokens method instead of the one identical in PathautoTokenTest.php.

Fixing failing test.

Another attempt. Sorry for the noise.

Question: Is it appropriate to alter arguments in existing class Interfaces in a minor release? For example, in AliasStorageHelperInterface, this patch updates the method from deleteMultiple($pids)to deleteMultiple(array $pids). While this is the proper Drupal standard, it could throw and error for anyone implementing the interface in other custom/contrib modules. Everything in the patch looks great, but I'm afraid to change the status to RTBC until someone can sign-off on this interface question.

Code review:
Excellent job updating coding standards. Beyond the issues found in linting, this patch also includes work to complete and tidy up comments as well as fixing whitespace, capitalization, and punctuation issues.

Unit testing:
Testing was conducted with Drupal 8.8.1 and Pathauto 8.x-1.x-dev. This patch includes changes to the tests themselves. Most notable, removing a method assertTokens as this functionality is already available in TokenTestTrait. All PHPUnit tests successfully passed.

Functional testing:
While these are all non-functional changes, I performed some sanity tests to reviews functions that were touched in this patch.
- cleanTokenValues: Tested this method by creating a pattern for content that used path in one of the alias segments. Verified that this default safe-value was not sanitized as expected.
- deleteMultiple and batchDelete: Confirmed that the delete multiple operations though the delete_bulk form works as expected.
- batchUpdate: Created a series of nodes using an alias. Altered the pattern and then regenerated the aliases using the action plugin on the content overview page.
- Pattern Edit Form: Verified that entity bundles appear on this form.

> Question: Is it appropriate to alter arguments in existing class Interfaces in a minor release? For example, in AliasStorageHelperInterface, this patch updates the method from deleteMultiple($pids)to deleteMultiple(array $pids).

No, it is not. That's an API change, and I don't like coding standard (changes) that have a functional impact on code. That shouldn't be a coding standard and it's not in enforced in core.

Lets ignore that change and I'm sure this needs a reroll, commit a few more focused changes. I'm a but unsure how to best address this. Large patches like this are hard to review, those are too small generate a lot of work for me. One issue per type of problem seems like a useful compromise, for those that have several problems at least.

Here is a rerolled patch.

I have not made any changes to it as it already is a large patch and someone should verify the reroll is OK before extending it.

I had a couple of conflicts also. They were on the tests.

After applying the patch the module is still showing the following error. Where many of them are Line indented incorrectly
Moving this to Needs Work.

FILE: /modules/contrib/pathauto/tests/modules/pathauto_custom_punctuation_test/pathauto_custom_punctuation_test.module
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] Missing file doc comment
-------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /modules/contrib/pathauto/tests/src/FunctionalJavascript/PathautoLocaleTest.php
----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
 61 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------


FILE: /modules/contrib/pathauto/tests/src/Kernel/PathautoKernelTest.php
--------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------
 404 | ERROR   | [x] Each index in a multi-line array must be on a new line
 404 | WARNING | [x] A comma should follow the last multiline array item. Found: 'string'
 409 | WARNING | [x] A comma should follow the last multiline array item. Found: 'tags'
 425 | WARNING | [x] A comma should follow the last multiline array item. Found: )
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------


FILE: /modules/contrib/pathauto/pathauto.module
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
 168 | WARNING | Avoid backslash escaping in translatable strings when possible, use "" quotes instead
-------------------------------------------------------------------------------------------------------


FILE: /modules/contrib/pathauto/src/AliasCleaner.php
-------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------
 236 | ERROR | [x] Whitespace found at end of line
 248 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------


FILE: /modules/contrib/pathauto/src/PathautoWidget.php
---------------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 12 LINES
---------------------------------------------------------------------------------------
 27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 29 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 30 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 32 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
---------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------


FILE: /modules/contrib/pathauto/src/Commands/PathautoCommands.php
--------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
 206 | ERROR | @throws tag comment must end with a full stop
--------------------------------------------------------------------------------------------------


FILE: /modules/contrib/pathauto/src/PathautoGeneratorInterface.php
---------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------
 76 | ERROR | [x] Data types in @param tags need to be fully namespaced
 81 | ERROR | [ ] Parameter comment must start with a capital letter
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

Thanks
Rajandro

Fixed all coding standards issues as mentioned in #15, please review.

Thank you @mrinalini9, I have applied and checked the patch rerolled_patch-3104764-17.patch, Now the patch is looking clean and fixed all the coding standard issues. I think we can move this forward.

Thanks
Rajandro

Hi @rajandro,

I have rerolled this patch #17 for replacing t() with $this->t() please take a look.

Please ignore my patch #20 as $this-t() failing in testcase.

Hi, i will review this last patch.

I cound't apply the last patch. So i dowloand the module and run phpcs to fix the codings standars.
I have found and fixed some issues but the following problems i dont know how to fixe.

FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/pathauto.module
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
 177 | WARNING | Avoid backslash escaping in translatable strings when possible, use "" quotes instead
------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/tests/src/FunctionalJavascript/PathautoLocaleTest.php
--------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 19 WARNINGS AFFECTING 19 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------
 169 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 171 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 172 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 173 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 174 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 175 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 176 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 177 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 178 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 179 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 180 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 183 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 185 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 186 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 187 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 188 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 189 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 190 | WARNING | Code after the RETURN statement on line 168 cannot be executed
 191 | WARNING | Code after the RETURN statement on line 168 cannot be executed
--------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/Plugin/pathauto/AliasType/EntityAliasTypeBase.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 301 | ERROR | The text '@deprecated Use \Drupal\pathauto\PathautoState::bulkDelete() instead.' does not match the standard format: @deprecated in %deprecation-version% and is removed from
     |       | %removal-version%. %extra-info%.
 301 | ERROR | Each @deprecated tag must have a @see tag immediately following it

So i need someone to review that.

Hi, my last patch have failed in tests. I use the last patch (26) and this didnt work. So i rerolled the module and apply the 17 patch, because it is the last patch working. After applying, i found this issues :

FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/pathauto.install
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
 137 | ERROR | [x] list(...) is forbidden, use [...] instead.
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/pathauto.module
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
  16 | WARNING | Line exceeds 80 characters; contains 88 characters
  55 | ERROR   | The array declaration extends to column 656 (the limit is 80). The array content should be split up over multiple lines
 148 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 164 | ERROR   | The array declaration extends to column 220 (the limit is 80). The array content should be split up over multiple lines
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/tests/src/Functional/PathautoMassDeleteTest.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 6 WARNINGS AFFECTING 8 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
  89 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  90 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 109 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 111 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 135 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 136 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 163 | ERROR   | The array declaration extends to column 111 (the limit is 80). The array content should be split up over multiple lines
 163 | ERROR   | The array declaration extends to column 110 (the limit is 80). The array content should be split up over multiple lines
 194 | ERROR   | The array declaration extends to column 98 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/tests/src/Functional/PathautoNodeWebTest.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 9 WARNINGS AFFECTING 11 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------
  79 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  97 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  98 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  98 | ERROR   | The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
 106 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 107 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 107 | ERROR   | The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
 124 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 179 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 186 | ERROR   | Missing short description in doc comment
 191 | ERROR   | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
 287 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 288 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------------


FILE: .../guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/tests/src/Functional/PathautoEnablingEntityTypesTest.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------
 61 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/tests/src/Functional/PathautoTaxonomyWebTest.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------
 87 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 96 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
---------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/tests/src/Functional/PathautoTestHelperTrait.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 17 ERRORS AND 1 WARNING AFFECTING 18 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------
  75 | ERROR   | [x] Missing function doc comment
  79 | ERROR   | [ ] The array declaration extends to column 223 (the limit is 80). The array content should be split up over multiple lines
  82 | ERROR   | [x] Missing function doc comment
  90 | ERROR   | [x] Missing function doc comment
  98 | ERROR   | [x] Missing function doc comment
 102 | ERROR   | [x] Missing function doc comment
 110 | ERROR   | [x] Missing function doc comment
 118 | ERROR   | [x] Missing function doc comment
 128 | ERROR   | [x] Missing function doc comment
 134 | ERROR   | [x] Missing function doc comment
 139 | ERROR   | [x] Missing function doc comment
 144 | ERROR   | [ ] Missing short description in doc comment
 145 | ERROR   | [ ] Missing parameter comment
 147 | ERROR   | [ ] Description for the @return value is missing
 161 | ERROR   | [x] Missing function doc comment
 172 | ERROR   | [x] Missing function doc comment
 184 | ERROR   | [x] Missing function doc comment
 186 | WARNING | [x] '@todo - implement cache reset.' should match the format '@todo Fix problem X here.'
---------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 14 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/tests/src/Functional/PathautoBulkUpdateTest.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 7 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
  73 | ERROR   | [x] Missing function doc comment
  90 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 104 | ERROR   | [ ] The array declaration extends to column 102 (the limit is 80). The array content should be split up over multiple lines
 104 | ERROR   | [ ] The array declaration extends to column 101 (the limit is 80). The array content should be split up over multiple lines
 107 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 112 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 116 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 125 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 130 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 156 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/tests/src/Functional/PathautoUserWebTest.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------
 88 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------------


FILE: ...home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/tests/src/Functional/PathautoSettingsFormWebTest.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------
 133 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 134 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 140 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 144 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 223 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 224 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/tests/src/Kernel/PathautoEntityWithStringIdTest.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------
 81 | ERROR | [ ] Parameter tags must be defined first in a doc comment
 82 | ERROR | [x] Parameter comment must end with a full stop
------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/tests/src/Kernel/PathautoKernelTest.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 15 ERRORS AND 5 WARNINGS AFFECTING 20 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
  30 | ERROR   | [ ] Missing member variable doc comment
  45 | ERROR   | [ ] Missing member variable doc comment
 178 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 248 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 269 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 296 | WARNING | [ ] Line exceeds 80 characters; contains 102 characters
 323 | ERROR   | [ ] The array declaration extends to column 116 (the limit is 80). The array content should be split up over multiple lines
 332 | ERROR   | [ ] The array declaration extends to column 130 (the limit is 80). The array content should be split up over multiple lines
 356 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 373 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 383 | ERROR   | [ ] The array declaration extends to column 86 (the limit is 80). The array content should be split up over multiple lines
 431 | ERROR   | [ ] The array declaration extends to column 144 (the limit is 80). The array content should be split up over multiple lines
 453 | ERROR   | [x] Missing function doc comment
 487 | ERROR   | [ ] The array declaration extends to column 92 (the limit is 80). The array content should be split up over multiple lines
 495 | ERROR   | [ ] The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
 500 | ERROR   | [ ] The array declaration extends to column 95 (the limit is 80). The array content should be split up over multiple lines
 521 | ERROR   | [ ] The array declaration extends to column 110 (the limit is 80). The array content should be split up over multiple lines
 522 | ERROR   | [ ] The array declaration extends to column 110 (the limit is 80). The array content should be split up over multiple lines
 526 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 586 | ERROR   | [ ] The array declaration extends to column 86 (the limit is 80). The array content should be split up over multiple lines
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/tests/src/Kernel/PathautoTokenTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 24 | ERROR   | [x] Missing function doc comment
 39 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 40 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
 83 | ERROR   | [x] Missing function doc comment
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: ...ome/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/tests/src/FunctionalJavascript/PathautoLocaleTest.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 27 WARNINGS AFFECTING 27 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------
  45 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  65 | ERROR   | The array declaration extends to column 102 (the limit is 80). The array content should be split up over multiple lines
  83 | ERROR   | The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
  87 | ERROR   | The array declaration extends to column 120 (the limit is 80). The array content should be split up over multiple lines
 117 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 156 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 159 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 161 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 162 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 162 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 163 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 164 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 165 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 166 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 166 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 167 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 168 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 169 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 170 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 173 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 175 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 176 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 177 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 178 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 178 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 179 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 179 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 180 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 181 | WARNING | Code after the RETURN statement on line 158 cannot be executed
 208 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 222 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/tests/src/FunctionalJavascript/PathautoUiTest.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 14 WARNINGS AFFECTING 16 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------
  60 | ERROR   | [x] Missing function doc comment
  70 | ERROR   | [x] Missing function doc comment
 137 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 140 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 146 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 149 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 157 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 165 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 166 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 168 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 184 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 185 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 187 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 197 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 199 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 200 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/PathautoFieldItemList.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------------
  7 | ERROR | [x] Missing class doc comment
  9 | ERROR | [ ] Missing short description in doc comment
 29 | ERROR | [ ] Missing short description in doc comment
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/AliasCleanerInterface.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------------
  5 | ERROR   | Missing short description in doc comment
 16 | WARNING | Line exceeds 80 characters; contains 81 characters
 55 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/Entity/PathautoPattern.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------------------
  93 | ERROR | Missing short description in doc comment
 119 | ERROR | Missing short description in doc comment
 124 | ERROR | Missing short description in doc comment
---------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/PathautoGeneratorInterface.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------------------
 13 | ERROR | Doc comment short description must start with a capital letter
 13 | ERROR | Doc comment short description must end with a full stop
 18 | ERROR | Doc comment short description must start with a capital letter
 18 | ERROR | Doc comment short description must end with a full stop
 23 | ERROR | Doc comment short description must start with a capital letter
 23 | ERROR | Doc comment short description must end with a full stop
 53 | ERROR | Description for the @return value is missing
-------------------------------------------------------------------------------------------------------------------------------------


FILE: ...ome/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/Plugin/pathauto/AliasType/EntityAliasTypeBase.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------
 193 | ERROR | The array declaration extends to column 126 (the limit is 80). The array content should be split up over multiple lines
 298 | ERROR | The text '@deprecated Use \Drupal\pathauto\PathautoState::bulkDelete() instead.' does not match the standard format: @deprecated in
     |       | %deprecation-version% and is removed from %removal-version%. %extra-info%.
 298 | ERROR | Each @deprecated tag must have a @see tag immediately following it
------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/Plugin/migrate/source/PathautoPattern.php
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------------
  98 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
 117 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/AliasCleaner.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 33 ERRORS AFFECTING 33 LINES
---------------------------------------------------------------------------------------------------------------------------------------
 197 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
 295 | ERROR | The array declaration extends to column 106 (the limit is 80). The array content should be split up over multiple lines
 296 | ERROR | The array declaration extends to column 120 (the limit is 80). The array content should be split up over multiple lines
 297 | ERROR | The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines
 298 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
 299 | ERROR | The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines
 300 | ERROR | The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines
 301 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
 302 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
 303 | ERROR | The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines
 304 | ERROR | The array declaration extends to column 103 (the limit is 80). The array content should be split up over multiple lines
 305 | ERROR | The array declaration extends to column 102 (the limit is 80). The array content should be split up over multiple lines
 306 | ERROR | The array declaration extends to column 103 (the limit is 80). The array content should be split up over multiple lines
 307 | ERROR | The array declaration extends to column 103 (the limit is 80). The array content should be split up over multiple lines
 308 | ERROR | The array declaration extends to column 104 (the limit is 80). The array content should be split up over multiple lines
 309 | ERROR | The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines
 310 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
 311 | ERROR | The array declaration extends to column 92 (the limit is 80). The array content should be split up over multiple lines
 312 | ERROR | The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines
 313 | ERROR | The array declaration extends to column 96 (the limit is 80). The array content should be split up over multiple lines
 314 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
 315 | ERROR | The array declaration extends to column 95 (the limit is 80). The array content should be split up over multiple lines
 316 | ERROR | The array declaration extends to column 114 (the limit is 80). The array content should be split up over multiple lines
 317 | ERROR | The array declaration extends to column 91 (the limit is 80). The array content should be split up over multiple lines
 318 | ERROR | The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines
 319 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
 320 | ERROR | The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines
 321 | ERROR | The array declaration extends to column 101 (the limit is 80). The array content should be split up over multiple lines
 322 | ERROR | The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
 323 | ERROR | The array declaration extends to column 98 (the limit is 80). The array content should be split up over multiple lines
 324 | ERROR | The array declaration extends to column 101 (the limit is 80). The array content should be split up over multiple lines
 325 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
 326 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/Form/PathautoAdminDelete.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 6 LINES
---------------------------------------------------------------------------------------------------------------------------------------
  90 | ERROR | The array declaration extends to column 181 (the limit is 80). The array content should be split up over multiple lines
 128 | ERROR | The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
 128 | ERROR | The array declaration extends to column 96 (the limit is 80). The array content should be split up over multiple lines
 134 | ERROR | The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines
 138 | ERROR | The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines
 139 | ERROR | The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines
 150 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/Form/PatternEditForm.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------------------------
 126 | ERROR | The array declaration extends to column 86 (the limit is 80). The array content should be split up over multiple lines
 145 | ERROR | The array declaration extends to column 102 (the limit is 80). The array content should be split up over multiple lines
 228 | ERROR | The array declaration extends to column 106 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/PathautoWidget.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
 35 | WARNING | Line exceeds 80 characters; contains 144 characters
-------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/VerboseMessenger.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
 68 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/PathautoState.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 121 | ERROR | Description for the @return value is missing
------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/AliasUniquifier.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
 105 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/Commands/PathautoCommands.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 11 LINES
-------------------------------------------------------------------------------------------------------------------------------------------
  65 | ERROR | [ ] Doc comment short description must start with a capital letter
  69 | ERROR | [ ] Parameter tags must be defined first in a doc comment
 111 | ERROR | [x] Doc comment short description must end with a full stop
 115 | ERROR | [ ] Parameter tags must be defined first in a doc comment
 140 | ERROR | [ ] Type hint "array" missing for $options
 148 | ERROR | [ ] The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
 148 | ERROR | [ ] The array declaration extends to column 96 (the limit is 80). The array content should be split up over multiple lines
 153 | ERROR | [ ] The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines
 175 | ERROR | [ ] Missing short description in doc comment
 188 | ERROR | [ ] Missing short description in doc comment
 202 | ERROR | [ ] Missing short description in doc comment
 221 | ERROR | [ ] Missing short description in doc comment
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/PathautoPatternInterface.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
-----------------------------------------------------------------------------------------------------------------------------------
  15 | ERROR | Description for the @return value is missing
  22 | ERROR | Missing parameter comment
  31 | ERROR | Description for the @return value is missing
  35 | ERROR | Missing short description in doc comment
  36 | ERROR | Description for the @return value is missing
  43 | ERROR | Description for the @return value is missing
  60 | ERROR | Description for the @return value is missing
 128 | ERROR | Description for the @return value is missing
 149 | ERROR | Description for the @return value is missing
 174 | ERROR | Missing parameter type
 177 | ERROR | Description for the @return value is missing
-----------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/PathautoPatternListBuilder.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
 40 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/src/AliasUniquifierInterface.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
 13 | WARNING | Line exceeds 80 characters; contains 81 characters
-----------------------------------------------------------------------------------------------------------------------------------


FILE: /home/guilhermerabelo/Contribution/Project4/recommended-project/web/modules/contrib/pathauto/pathauto.api.php
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
 10 | ERROR | Missing short description in doc comment

I fixed this issues.
Waiting for review.

I'll review this

The patch in #30 fixed almost all messages in PHPCS, but there are some t() calls message that there aren't possible to change because tests will fail with the changes. There are also a messages about some returns, but as it was said in #28 I don't know how to fix them.
I just changed one line in #30 patch to the test pass.
Kindly review it.

I'll review this.

After the #33, I still found some warnings in phpcs. So I made a patch to correct them. But there are still 2 errors remaining:

• In the @deprecated warning, I added the issue that changed this line, but I wasn't able to find which version the code will be removed.
• About the return warning, I think an another issue should be open to discuss about it.

To be honest, working on 100kb coding standard patches is really not a good use of your time. Reviewing this will take a ton of time and it's extremely unlikely to get a patch like this committed without planning this with the maintainer and scheduling it between other things.

Until there are better tools in place to manage this, like an easy way to opt-in to specific coding standards so it can be done gradually like core (and failing patches that don't match), I have no intention of committing a patch of this size that will break a lot of other patches that people are using.

Patch #35 is not applying to me.

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

The coding standards verification was performed; however, some functions or calls cannot be corrected as they would affect the module's functionality.