Implement path alias changes in 8.x-1.x

patch #11 isnt working for me. the table `views_url_alias_node` was empty.

looking at the function `views_url_alias_node_rebuild()`, i was able to populate the table by changing the join() method's parameters from `source` to `path`.

should we also be changing all `source` to `path`? question arises from seeing this:

function views_url_alias_node_form_path_alias_delete_form_submit($form, FormStateInterface $form_state) {
  $build_info = $form_state->getBuildInfo();
  if (isset($build_info['args'][0])) {
    $alias_id = $build_info['args'][0];
    /** @var \Drupal\Core\Path\AliasStorage $alias_storage */
    $alias_storage = \Drupal::service('path.alias_storage');
    $alias = $alias_storage->load([
      'id' => $alias_id,
    ]);
    if (preg_match('#^/node/(\d+)$#', $alias['source'], $match)) { // <-- THIS HERE '$alias['source']
      $nid = $match[1];
      views_url_alias_node_delete($nid);
    }
  }
}

patch from #15 works for me! everything seems like it was before the v8.8 update. Thanks @esod!

Patch at #15 works for me as well, on 8.8.1

#15 works and looks good to me.

Any way this can be added to a release, or merged to the dev branch? I want to also apply the Drupal 9 patch (https://www.drupal.org/project/views_url_alias/issues/3142138), and this is blocking us because we need this as well. Patch from #15 has been working well for me for quite some time.

I encountered the same issue as #20. Here is a merged patch with 9 changes from 3142138

Updated the patch from #21 to be compatible with the Drupal 9 issue fork https://git.drupalcode.org/issue/views_url_alias-3142138/-/tree/3142138-... . The fork already includes changes required for Drupal 9 as well as some other fixes from the patch above, so the #21 patch didn't apply against that branch

confirming that patch in 22 works with issue branch views_url_alias-3142138. maybe someday we can go back to normal... doubt it but hoping

Couldn't apply a patch to the 8.x-2.x-dev branch.

This ticket specifically says it is for the 8.x-1.x branch, so setting back to that.

The matching issue for 8.x-2.x seems to be #3086817: Prepare for the path alias changes in Drupal 8.8.

FWIW, regardless of this, I was unable to get either patch to apply against either version.

Do we need that task taking into account that branch 8.x-1.x-dev is for Drupal before 8.8, and and this version of the Drupal is not maintained any more?
I propose to close the Issue, and ones that need that fix for their old Drupal 8 sites - can apply patch.

Having had no replies in a long time, I think we can close this as outdated.