CommentFileSizeAuthor
#10 3099673-10.patch1.15 KBvoleger
#9 WhatsApp Image 2020-04-29 at 08.57.21.jpeg91.3 KBilgnerfagundes
#6 3099673-6.patch1.68 KBsidharthap
#5 3099673-5.patch1.67 KBsidharthap
#2 3099673-02.patch1.45 KBvoleger

Comments

voleger created an issue. See original summary.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Assigned: voleger » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3099673-02.patch1.45 KB

Replacement introduced in drupal:8.8.0

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I don't really feel comfortable requiring 8.8 quite yet, so I want to let this hold for a while.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Needs work

This needs to update core_version_requirement as well.

sidharthap’s picture

sidharthap
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3099673-5.patch1.67 KB

Updated core_version_requirement.

sidharthap’s picture

sidharthap
Primary language English
commented
StatusFileSize
new 3099673-6.patch1.68 KB

Core key removed from info file.

salah1’s picture

salah1
Location VA, U.S
commented
Parent issue: » #3004330: [META] Prepare module for Drupal 9
neclimdul’s picture

neclimdul
He/Him
commented 
+++ b/xmlsitemap.module
@@ -422,7 +422,9 @@ function xmlsitemap_sitemap_get_file(XmlSitemapInterface $sitemap, $chunk = 'ind
-  foreach (file_scan_directory($dir, '/\.xml$/') as $file) {
+  /** @var \Drupal\Core\File\FileSystemInterface $file_system */
+  $file_system = \Drupal::service('file_system');
+  foreach ($file_system->scanDirectory($dir, '/\.xml$/') as $file) {

Do we care about the exception handling and directory checks file_scan_directory was doing?

Otherwise looks great.

ilgnerfagundes’s picture

ilgnerfagundes commented
Status: Needs review » Needs work
StatusFileSize
new WhatsApp Image 2020-04-29 at 08.57.21.jpeg91.3 KB

The patch does not apply, wouldn't it be better to correct these conflicts already?

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Status: Needs work » Needs review
StatusFileSize
new 3099673-10.patch1.15 KB
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Priority: Normal » Major
Related issues: +#2978936: Update tests for Drupal 9 based testing

Is a blocker for #2978936: Update tests for Drupal 9 based testing

pifagor’s picture

pifagor commented
Status: Needs review » Reviewed & tested by the community

  • pifagor committed 1744784 on 8.x-1.x authored by voleger 
    Issue #3099673 by voleger, sidharthap, ilgnerfagundes, salah1, neclimdul...
pifagor’s picture

pifagor commented
Status: Reviewed & tested by the community » Fixed
neclimdul’s picture

neclimdul
He/Him
commented

Do we care about the exception handling and directory checks file_scan_directory was doing?

Guess that's a no :-D Thanks!

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented

Oh, sorry @neclimdul here is a followup #3134540-2: Add exception handling in the xmlsitemap_sitemap_get_max_filesize function

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.