With UI Pattern settings it is easy to add settings to a UI-Pattern (Link: https://www.drupal.org/project/ui_patterns).
A setting can be a modifier, a background color, the column padding etc.

Note about similar projects

As I know there is no other module to handle settings for UI-Patterns. Only variants are supported.

Project link

https://www.drupal.org/project/ui_patterns_settings

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/ui_patterns_settings.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-ui_patterns_se...

Comments

Christian.wiedemann created an issue. See original summary.

sch4lly’s picture

sch4lly commented
Status: Needs review » Needs work

Pareview report:

  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
  • The ui_patterns_settings.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
FILE: ...or/drupal/pareviewsh/pareview_temp/src/UiPatternsSettingsManager.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 37 | WARNING | \Drupal calls should be avoided in classes, use
    |         | dependency injection instead
--------------------------------------------------------------------------


FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/src/UiPatternsSettings.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 50 | WARNING | Unused variable $bind.
--------------------------------------------------------------------------

Time: 1.14 secs; Memory: 4Mb

This automated report was generated with PAReview.sh, your friendly project application review script.


FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
 49 | WARNING | Line exceeds 80 characters; contains 180 characters
 54 | WARNING | Line exceeds 80 characters; contains 111 characters
 69 | WARNING | Line exceeds 80 characters; contains 120 characters
 77 | WARNING | Line exceeds 80 characters; contains 94 characters
--------------------------------------------------------------------------


FILE: ...000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/CHANGELOG.md
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../ui_patterns_settings_render_test/templates/settings.ui_patterns.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 44 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 2.06 secs; Memory: 6Mb
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

I have the Git instructions for non-maintainer users and the link to the PAReview checklist.

christian.wiedemann’s picture

christian.wiedemann commented

I have fixed all open issues from PAReview expect the static inside class because it's inside the create method. So from my point of view this is correct.

christian.wiedemann’s picture

christian.wiedemann commented
Status: Needs work » Needs review
sch4lly’s picture

sch4lly commented
Status: Needs review » Reviewed & tested by the community

Looks good!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.