Problem/Motivation
- Translation Link
- t('') function
Proposed resolution
- Create new translation for link
- Use $this->t
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | 3093666-15.patch | 10.37 KB | andypost |
| #15 | interdiff.txt | 970 bytes | andypost |
| #14 | interdiff.txt | 7.86 KB | andypost |
Comments
Comment #2
saidatomComment #3
saidatomComment #4
saidatomComment #5
gregglesThanks for your help!
Testing says that the patch failed to apply and I tried manually and it failed to apply, so marking as needs work.
Comment #6
saidatomComment #7
saidatomComment #8
gregglesMoving to needs work for the test fail.
Comment #9
saidatomComment #10
saidatomComment #11
saidatomComment #12
saidatomComment #13
andypostexcept this duplicated calls to assertSession() better use local var
Comment #14
andypostThe patch mixing "Link" as render object and string to use for translation - reverted.
Also a bit of clean-up
Comment #15
andypostAnd the check should be against start theme, so better check for own error message
Comment #16
andypostI gonna commit it and polish remains in #3037323: Remove usage of deprecated methods and functions
Comment #18
andypostAfter deprecations new release is unlocked