Problem/Motivation

#3082655: Specify the $defaultTheme property in all functional tests just landed in 8.8.x. Yay! This is actually a Good Thing(tm). ;)
But it's going to break our 8.8.x tests again now that #3090175: Let tests fail on deprecation notices is in. ;)

Proposed resolution

Explicitly define this in all our Functional and FunctionalJavascript tests:

  /**
   * {@inheritdoc}
   */
  protected $defaultTheme = 'stark';

If any tests break b/c of it, we can use 'classy' instead. We can also consider immediately fixing those test assertions to not rely on classy markup (hopefully this won't be too big a job) as part of this issue.

Thankfully, this is available in 8.7.x, so this won't add to the list at #3093193: Require Drupal 8.8

Remaining tasks

  1. Do it.
  2. See if any of our tests are depending on classy markup.
  3. Decide what to do with them (fix here vs. set defaultTheme to classy and open followups)
  4. Commit

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3093294-3.patch2.08 KBdww

Comments

dww created an issue. See original summary.

dww’s picture

Assigned: Unassigned » dww

Giving this a spin, stay tuned.

dww’s picture

Status: Active » Needs review
StatusFileSize
new2.08 KB

Sweet, all passes locally with 'stark'. Bye bye, classy!

I'll let the bot show happiness on all branches, then commit.

p.s. This doesn't hurt us at all in 8.6.x, since setting a protected member that's ignored does no harm...

  • dww committed e116ea9 on 8.x-1.x
    Issue #3093294 by dww: Specify the $defaultTheme property in all...
dww’s picture

Assigned: dww » Unassigned
Status: Needs review » Fixed

All green on all branches. Committed + pushed to 8.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.