Problem/Motivation
#3082655: Specify the $defaultTheme property in all functional tests just landed in 8.8.x. Yay! This is actually a Good Thing(tm). ;)
But it's going to break our 8.8.x tests again now that #3090175: Let tests fail on deprecation notices is in. ;)
Proposed resolution
Explicitly define this in all our Functional and FunctionalJavascript tests:
/**
* {@inheritdoc}
*/
protected $defaultTheme = 'stark';
If any tests break b/c of it, we can use 'classy' instead. We can also consider immediately fixing those test assertions to not rely on classy markup (hopefully this won't be too big a job) as part of this issue.
Thankfully, this is available in 8.7.x, so this won't add to the list at #3093193: Require Drupal 8.8
Remaining tasks
- Do it.
- See if any of our tests are depending on classy markup.
- Decide what to do with them (fix here vs. set defaultTheme to classy and open followups)
- Commit
User interface changes
API changes
Data model changes
Release notes snippet
Comments
Comment #2
dwwGiving this a spin, stay tuned.
Comment #3
dwwSweet, all passes locally with 'stark'. Bye bye, classy!
I'll let the bot show happiness on all branches, then commit.
p.s. This doesn't hurt us at all in 8.6.x, since setting a protected member that's ignored does no harm...
Comment #5
dwwAll green on all branches. Committed + pushed to 8.x-1.x
Comment #7
chris matthews commented