php drupal-check.phar modules/contrib/tac_lite/
 8/8 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------- 
  Line   src/Form/ConfigForm.php                            
 ------ --------------------------------------------------- 
  34     Call to deprecated method url() of class Drupal.   
  99     Call to deprecated function drupal_set_message().  
  100    Call to deprecated method url() of class Drupal.   
 ------ --------------------------------------------------- 

 ------ ------------------------------------------------------------ 
  Line   src/Form/SchemeForm.php                                     
 ------ ------------------------------------------------------------ 
  124    Call to deprecated method url() of class Drupal.            
  145    Call to deprecated function drupal_set_message().           
  145    Call to deprecated method url() of class Drupal.            
  174    Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ -------------------------------------------------- 
  Line   src/Form/UserAccessForm.php                       
 ------ -------------------------------------------------- 
  67     Call to deprecated method url() of class Drupal.  
  76     Call to deprecated method url() of class Drupal.  
 ------ -------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------- 
  Line   tac_lite.module                                                                    
 ------ ----------------------------------------------------------------------------------- 
  23     Call to deprecated method l() of class Drupal.                                     
  35     Call to deprecated method url() of class Drupal.                                   
  109    Call to deprecated function drupal_set_message().                                  
  110    Call to deprecated method url() of class Drupal.                                   
  125    Call to deprecated method entityManager() of class Drupal.                         
  140    Call to deprecated method getVocabularyId() of class Drupal\taxonomy\Entity\Term.  
  254    Call to deprecated function db_or().                                               
 ------ ----------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------ 
  Line   tac_lite_create/tac_lite_create.module                      
 ------ ------------------------------------------------------------ 
  55     Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

                                                                                                                        
 [ERROR] Found 17 errors
CommentFileSizeAuthor
#5 deprecated-3092130-5.patch839 byteskalvis
#5 upgrade_status_report.png71.96 KBkalvis
#3 deprecated-3092130-3.patch10.85 KBjidrone
#2 deprecated-3092130-2.patch10.45 KBsergiu stici

Issue fork tac_lite-3092130

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new deprecated-3092130-2.patch10.45 KB

Here's the patch, please review.

jidrone’s picture

jidrone commented
StatusFileSize
new deprecated-3092130-3.patch10.85 KB

My patch is an update of new code deprecations from #3141842: Automated Drupal 9 compatibility fixes with the additions in the info file to make it compatible with Drupal 9.

  • mukila committed 9708884 on 8.x-1.x 
    Issue #3092130 by Sergiu Stici, jidrone: Deprecated Code Report
kalvis’s picture

kalvis commented
StatusFileSize
new upgrade_status_report.png71.96 KB
new deprecated-3092130-5.patch839 bytes

Seems that there is still usage of deprecated getVocabularyId in tac_lite.module file.
Also the core_version_requirement is missing from tac_lite_create/tac_lite_create.info.yml
upgrade_status_report
Here's the patch.

maico de jong’s picture

maico de jong
Primary language Dutch
commented
Category: Task » Bug report
Status: Needs review » Reviewed & tested by the community

Without patch #5 node access rebuild no longer works in Drupal 9 so changing this to a bug report.
Tested with the patch: problem solved

justcaldwell’s picture

justcaldwell
he/him
Primary language English
Location Austin, Texas
commented

#5 also adds the required core_version_requirement for the tac_lite_create submodule (missed in the previous D9 compatibility patch).

+1 for RTBC and a new release.

AlexJ’s picture

AlexJ commented

Patch #5 solved my issue, thanks for the great module and work.
https://www.drupal.org/project/tac_lite/issues/3197673#comment-13994588

justcaldwell’s picture

justcaldwell
he/him
Primary language English
Location Austin, Texas
commented

I just messaged @mukila directly from their contact page to request a review of this issue.

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented

+1 for RTBC'ing this. The patch looks good, we've tested it and can confirm it works, and it would be awesome if this could be committed and a new release rolled; at the moment the module page states the latest release is compatible with Drupal 9, and it really isn't.

zany’s picture

zany commented

+1 for RTBC

#5 is clean, minimal, readable and solves an issue.

ifrik’s picture

ifrik
she/her
commented

Thanks, that patch works for me as well.

joelseguin made their first commit to this issue’s fork.

arlina’s picture

arlina commented

Confirmed that #5 works and allows the site to rebuild permissions again. Thanks.

laravz’s picture

laravz commented

We should probably check whether the issue fork MR has the latest changes from patch #5. Then we would need a maintainer to merge those changes (or become a co-maintainer and do it ourselves).

davemybes’s picture

davemybes commented

Can confirm that #5 works and prevents fatal errors. Nice work! Sadly no commits since Aug 2020, so just running it as a patch in composer.json for now. Note that this won't actually fix the tac_lite_create module being flagged as non-D9 in some cases, but I don't use it, so that doesn't matter to me.

nicocin’s picture

nicocin commented

#5 works fine. Thanks !

boobaa’s picture

boobaa
he/him
commented
Version: 8.x-1.x-dev » 8.x-1.5
Priority: Normal » Major

Without the patch in #3092130-5: Deprecated Code Report, this module cannot work properly in drupal-9.3.2. As the latest release claims D9 as supported, I'm also bumping the priority to major. The patch in #5 solves the problem, tho.

sl27257’s picture

sl27257
Location Stockholm
commented

Confirm that the #5 fixes rebuilding of permissions crash for Tac Lite and D9.3.2. Please release it!

  • grndlvl committed daf0428 on 8.x-1.x authored by kalvis 
    Issue #3092130 by kalvis, Sergiu Stici, joelseguin, jidrone,...

grndlvl credited mukila.

grndlvl’s picture

grndlvl commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.