Closed (fixed)
Project:
Recurring Events
Version:
8.x-1.x-dev
Component:
Recurring Events (Main module)
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
29 Oct 2019 at 02:16 UTC
Updated:
13 Apr 2020 at 16:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
owenbush commentedThanks for this. I need to tighten up all validation on these recurrence types actually
Comment #3
owenbush commentedComment #4
siddhant.bhosale commentedComment #5
siddhant.bhosale commentedHi, I have fixed the issue and adding the patch for the same.
Comment #6
owenbush commentedThanks for the patch. I'll take a look at this soon.
Comment #7
the_glitch commentedPatch #5 creates bug with the recur type in series and series can't be saved.

Comment #8
naresh_bavaskarComment #9
naresh_bavaskarPlease review the new patch
Comment #10
owenbush commentedHey Siddhant and Naresh,
Thanks for the patches towards this issue. However, there is a bigger problem of field widget validation that needs to be addressed. I've attached a patch in which all of the special recurring events field widgets are responsible for their own validation.
The validation is more robust now because it checks individual fields and ensures they are completed as expected. I appreciate the work you put into this, however we need more validation than just checking the entire array is empty.
The patch also addresses some other issues which relate to validation for example checking that the consecutive recurring type is not generating too many instances, and also fixing the broken functionality with modifying date recurrence not triggering a prompt and diff table to approve those changes.
I also took the opportunity to use the StringTranslationTrait to update calls for `t()` to `$this->t()`
Comment #11
owenbush commentedI found a ksm() I forgot to remove. This patch has that removed.
Comment #12
owenbush commentedComment #14
owenbush commentedThis has been merged and marked as fixed. Thanks all for the patches and issue.