When registrations are enabled, if capacity field is left blank, no registrations are possible and the 'Unfortunately, this event is at capacity and there are no spaces available.' message is shown.

Suggest that no value equals unlimited capacity or that the field is mandatory.

I think unlimited capacity makes most sense.

CommentFileSizeAuthor
#11 recurring_events-unlimited_capacity-3090302-11.patch2.5 KBowenbush
#11 interdiff-3090302-9-11.txt1000 bytesowenbush
#9 recurring_events_3090302_9.patch1.53 KBowenbush
#9 interdiff-8-9.txt1.61 KBowenbush
#8 recurring_events_3090302_8.patch1.43 KBSnehal Brahmbhatt

Comments

MrPaulDriver created an issue. See original summary.

owenbush’s picture

owenbush commented

Good find, thanks Paul.

I'll get this looked at.

mrpauldriver’s picture

mrpauldriver commented

Help text to be worded accordingly.

mrpauldriver’s picture

mrpauldriver commented

Revisiting this today.

When completing the event form it is easy to miss 'Total Number of Spaces Available' field. If the field is not populated then registrations are not possible, because the event is at capacity. This is a bug.

Please make this field mandatory.

The field also need needs a something for unlimited capacity (-1 perhaps).

owenbush’s picture

owenbush commented

This one is on the roadmap to a 1.0 stable release as part of a bigger "form validation" piece, which is kind of lacking at this time.

owenbush’s picture

owenbush commented
Component: Code » Recurring Events Registration (Submodule)
owenbush’s picture

owenbush commented
Issue tags: +RE Stable Release Blocker
Snehal Brahmbhatt’s picture

Snehal Brahmbhatt commented
Status: Active » Needs review
StatusFileSize
new recurring_events_3090302_8.patch1.43 KB

@MrPaulDriver @owenbush Please find this patch to resolve the above-mentioned issue.

Hope this works for you flawlessly!

Thanks,
Snehal Brahmbhatt
https://www.drupal.org/user/3147795/track

owenbush’s picture

owenbush commented
StatusFileSize
new interdiff-8-9.txt1.61 KB
new recurring_events_3090302_9.patch1.53 KB

Thanks for the patch. There were a couple of issues:

1 - After you returned -1 for the capacity, you then also set the $capacity = 0; This won't run after the return so I removed that assignment.
2 - I moved the comment about that -1 capacity to above the line to make it more consistent with coding standards.
3 - When displaying the capacity the word 'Unlimited' should be translated, so I wrapped it in $this->t(), and also cleaned up the array a little because the line was over 80 characters.

Supplied are an interdiff and a new patch.

mrpauldriver’s picture

mrpauldriver commented

This is working nicely.

Suggest that help text on the edit form should be updated.

From:
Maximum number of attendees available for each series, or individual event

To:
Maximum number of attendees available for each series, or individual event. Leave blank for unlimited.

owenbush’s picture

owenbush commented
StatusFileSize
new interdiff-3090302-9-11.txt1000 bytes
new recurring_events-unlimited_capacity-3090302-11.patch2.5 KB

Good idea, Paul. Thanks. I've added an interdiff and a new patch.

mrpauldriver’s picture

mrpauldriver commented
Status: Needs review » Reviewed & tested by the community

Looks good.

  • owenbush committed e053f4e on 8.x-1.x 
    Issue #3090302 by owenbush, Snehal Brahmbhatt, MrPaulDriver:...
owenbush’s picture

owenbush commented
Status: Reviewed & tested by the community » Fixed

Super duper, thanks for all the help. This has been merged and marked as fixed.

owenbush’s picture

owenbush commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.