Media thumbnail dimensions are wrong for YouTube videos

I'm seeing this as well on 8.8.0 unfortunately.

After a bunch of dead ends, I think I've come up with a working workaround. Assuming you have a custom module, you'll need this in that module's .module file:

use Drupal\file\Entity\File;

/**
 * Implements hook_ENTITY_TYPE_presave().
 *
 * Fixes incorrect stored YouTube thumbnail dimensions by reading the actual
 * thumbnail image dimensions from the file. This is due to a Drupal core bug
 * that always stores YouTube thumbnails as 180x180, despite getting the correct
 * dimensions from the oEmbed data. This fix seems to work because the thumbnail
 * image has already been fetched by Drupal by the time this hook is invoked.
 *
 * Note that a media entity needs to be saved either programmatically or via the
 * Drupal UI for this to take effect.
 *
 * @param  Drupal\Core\Entity\EntityInterface $entity
 *   The media entity object.
 *
 * @see https://www.drupal.org/project/drupal/issues/3088168
 *   Drupal core issue detailing incorrect YouTube thumbnail dimensions.
 */
function YOUR_MODULE_media_presave(
  Drupal\Core\Entity\EntityInterface $entity
) {
  if (
    $entity->bundle()             === 'remote_video' &&
    // Note that the dimensions are provided to us as strings, not integers.
    $entity->thumbnail[0]->width  === "180" &&
    $entity->thumbnail[0]->height === "180"
  ) {
    // Create a File entity from the file ID.
    /** @var \Drupal\file\FileInterface|null A File entity or null if the ID is
        not found. */
    $file = File::load($entity->thumbnail[0]->target_id);

    // If we couldn't load a valid Drupal file entity, skip this entity.
    if (empty($file)) {
      return;
    }

    // Get the file URI so that we can read the stored file.
    $fileURI = $file->getFileUri();

    /** @var \Drupal\Core\Image\ImageFactory The Drupal core image factory
        service. */
    $imageFactory = \Drupal::service('image.factory');

    /** @var \Drupal\Core\Image\ImageInterface An Image instance built from the
        file URI. */
    $imageInstance = $imageFactory->get($fileURI);

    $dimensions = [
      'width'   => $imageInstance->getWidth(),
      'height'  => $imageInstance->getHeight(),
    ];

    if ($dimensions['width'] !== null && $dimensions['height'] !== null) {
      $entity->thumbnail[0]->width  = $dimensions['width'];
      $entity->thumbnail[0]->height = $dimensions['height'];
    }
  }
}

Don't forget to replace YOUR_MODULE with the machine name of your module, and clear Drupal's cache. If you only have a handful of remote_video media entities, you can just check them all in the admin UI and choose "Save media" from the "Action" drop-down. If you have a lot of entities you need to update, you can write a hook_update to have Drupal do them all for you.

We are also experiencing this on a 8.9.6 site using the video_embed_field module and YouTube.

We experienced this as well on 9.2.4. We have thumbnail downloads queued and as far as I can tell the 180 width/height comes from the default thumbnail image that gets referenced initially. The problem was that the updateThumbnail() did not seem to do anything for changing the stored width and height even though it fetched the correct thumbnail when cron was run.

If the thumbnail download is not queued then there is no problem (at least, presumably, until the thumbnail changes dimensions).

The workaround in #6 works fine to update the "stuck" thumbnail dimensions.

That's still there is 9.3.6
That's causing issues with the focal point module that cannot calculate an appropriate crop as it is based on the 180x180 size which is not accurate.

I opened a MR with a working version.
Here is the test-only patch that should demonstrate the issue.

Test on the MR are passing. Test on the test-only fail. This is the expected result.
Back to Needs review so someone can jump on this and push to forward.

Glad to see some movement on this!

Thanks for the MR @DuaelFr. It looks good, works as expected, has tests, and fixes an important bug, so moving straight to RTBC.

I wonder if this is caused by #2966656: Negotiate max width/height of oEmbed assets more intelligently? 🤔

In our case, we not only wanted the width and height values to update when an image media entity was updated, but also, the alt text.

We weren't able to find a complete working solution, but by combining the patch on this issue with a bundle class for image entities (as suggested on this issue) that would update the thumbnail each time an image entity is saved, we were able to get all the important values for the thumbnail to update.

Added a review to the MR in gitlab. We also need to move the MR to 9.5.x or 9.4.x. Plus getting a test run against 10.x would be useful.

• Changed MR target to 9.5.x
• Fixed nitpicks
• Answered @alexpott question in gitlab

Patch applies to 9.5.x and 10.1.x without problem.
Uploading it here to trigger tests.

This issue is being reviewed by the kind folks in Slack, #need-reveiw-queue. We are working to keep the size of Needs Review queue [2700+ issues] to around 200, following Review a patch or merge require as a guide.

Reviewing patch #23
Appears the threads were addressed and added to the patch.
Applied the patch locally verified without the fix the tests fail and with the fix they pass.
Code looks clean and comments make sense.

Feel comfortable marking.

Trying to credit @Edouard Cunibil only to realise it's @DuaelFr :)

Committed and pushed ac30a9859a to 10.1.x and 8f3a9be228 to 10.0.x and a7a492e994 to 9.5.x. Thanks!

Sorry for that @alexpott!
I'm too lazy to configure my git for every projects ^^
Thank you, though!

I use an online service to download youtube video thumbnails with correct dimensions, all these dimensions follow youtube's pre-defined algorithm. The dimension of youtube HD image is 1280X720 Pixels. it may be helpful for someone.