The Drupal\dfp\View\TagViewBuilder::buildPreTag method uses a hardcoded "http" scheme for the short tag links. This can causes mixed-content errors when the site is being run on https.

CommentFileSizeAuthor
#2 short_tag_uses_hardcoded_http_scheme-3088142-2.patch868 byteswells

Comments

wells created an issue. See original summary.

wells’s picture

wells
he/him/his
Primary language English
Location Seattle, WA
commented
StatusFileSize
new short_tag_uses_hardcoded_http_scheme-3088142-2.patch868 bytes

This patch resolves the issue by using the "//" scheme for short tags so that the site scheme is inherited.

mikeegoulding’s picture

mikeegoulding
he/him
Primary language English
commented
Status: Active » Reviewed & tested by the community

The patch applies fine and confirmed that ads render as short tags with https or http depending on the site protocol.

  • VladimirAus committed 3fc3fe9 on 8.x-1.x authored by wells 
    Issue #3088142 by wells, mikeegoulding, VladimirAus: Short tag uses...
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.