Deprecated Code Report [#3086994]

php drupal-check.phar modules/contrib/brightcove/
 90/90 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------------------------------------- 
  Line   brightcove.install                                                                                            
 ------ -------------------------------------------------------------------------------------------------------------- 
  226    Call to deprecated method applyUpdates() of class Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface.  
 ------ -------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------- 
  Line   brightcove.module                                                                    
 ------ ------------------------------------------------------------------------------------- 
  325    Call to deprecated method getVocabularyId() of class Drupal\taxonomy\TermInterface.  
 ------ ------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------- 
  Line   modules/media_entity_brightcove/src/Plugin/MediaEntity/Type/BrightcoveVideo.php  
 ------ --------------------------------------------------------------------------------- 
         Class Drupal\media_entity\MediaTypeBase not found and could not be autoloaded.   
 ------ --------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------------- 
  Line   src/BrightcovePlaylistListBuilder.php                                                                                       
 ------ ---------------------------------------------------------------------------------------------------------------------------- 
  21     Usage of deprecated trait Drupal\Core\Routing\LinkGeneratorTrait in class Drupal\brightcove\BrightcovePlaylistListBuilder.  
  106    Call to deprecated method l() of class Drupal\brightcove\BrightcovePlaylistListBuilder.                                     
 ------ ---------------------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/BrightcoveUtil.php                             
 ------ --------------------------------------------------- 
  198    Call to deprecated function drupal_set_message().  
  208    Call to deprecated function drupal_set_message().  
  214    Call to deprecated function drupal_set_message().  
  219    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------- 
  Line   src/BrightcoveVideoListBuilder.php                                                                                       
 ------ ------------------------------------------------------------------------------------------------------------------------- 
  23     Usage of deprecated trait Drupal\Core\Routing\LinkGeneratorTrait in class Drupal\brightcove\BrightcoveVideoListBuilder.  
  111    Call to deprecated method l() of class Drupal\brightcove\BrightcoveVideoListBuilder.                                     
 ------ ------------------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------- 
  Line   src/Commands/BrightcoveCommands.php                                        
 ------ --------------------------------------------------------------------------- 
         Class Drush\Commands\DrushCommands not found and could not be autoloaded.  
 ------ --------------------------------------------------------------------------- 

 ------ ----------------------------------------------------- 
  Line   src/Controller/BrightcoveSubscriptionController.php  
 ------ ----------------------------------------------------- 
  192    Call to deprecated function drupal_set_message().    
  235    Call to deprecated function drupal_set_message().    
  267    Call to deprecated function drupal_set_message().    
  287    Call to deprecated function drupal_set_message().    
  290    Call to deprecated function drupal_set_message().    
  309    Call to deprecated function drupal_set_message().    
  312    Call to deprecated function drupal_set_message().    
  379    Call to deprecated function drupal_set_message().    
  382    Call to deprecated function drupal_set_message().    
 ------ ----------------------------------------------------- 

 ------ ------------------------------------------------------- 
  Line   src/Entity/BrightcoveVideo.php                         
 ------ ------------------------------------------------------- 
  172    Call to deprecated function file_prepare_directory().  
  924    Call to deprecated function drupal_set_message().      
  928    Call to deprecated function drupal_set_message().      
 ------ ------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/BrightcoveAPIClientDeleteForm.php         
 ------ --------------------------------------------------- 
  253    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------- 
  Line   src/Form/BrightcoveAPIClientForm.php                                              
 ------ ---------------------------------------------------------------------------------- 
  320    Call to deprecated function drupal_set_message().                                 
  344    Call to deprecated function drupal_set_message().                                 
  353    Call to deprecated method urlInfo() of class Drupal\Core\Entity\EntityInterface.  
 ------ ---------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------- 
  Line   src/Form/BrightcoveInlineForm.php                                                             
 ------ ---------------------------------------------------------------------------------------------- 
         Class Drupal\inline_entity_form\Form\EntityInlineForm not found and could not be autoloaded.  
 ------ ---------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/BrightcovePlaylistForm.php                
 ------ --------------------------------------------------- 
  108    Call to deprecated function drupal_set_message().  
  114    Call to deprecated function drupal_set_message().  
  121    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/BrightcoveSubscriptionDeleteForm.php      
 ------ --------------------------------------------------- 
  64     Call to deprecated function drupal_set_message().  
  79     Call to deprecated function drupal_set_message().  
  82     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/BrightcoveSubscriptionForm.php            
 ------ --------------------------------------------------- 
  98     Call to deprecated function drupal_set_message().  
  105    Call to deprecated function drupal_set_message().  
  108    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/BrightcoveTextTrackForm.php               
 ------ --------------------------------------------------- 
  33     Call to deprecated function drupal_set_message().  
  39     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/BrightcoveVideoForm.php                   
 ------ --------------------------------------------------- 
  265    Call to deprecated function drupal_set_message().  
  271    Call to deprecated function drupal_set_message().  
  278    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ----------------------------------------------------------------------- 
  Line   src/Playlist.php                                                       
 ------ ----------------------------------------------------------------------- 
         Class Brightcove\Item\Playlist not found and could not be autoloaded.  
 ------ ----------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldWidget/BrightcoveInlineEntityFormComplex.php                                                       
 ------ ------------------------------------------------------------------------------------------------------------------------- 
         Class Drupal\inline_entity_form\Plugin\Field\FieldWidget\InlineEntityFormComplex not found and could not be autoloaded.  
 ------ ------------------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------- 
  Line   src/Video.php                                                             
 ------ -------------------------------------------------------------------------- 
         Class Brightcove\Item\Video\Video not found and could not be autoloaded.  
 ------ -------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 46 errors

Comment	File	Size	Author
#5	Deprecated-Code-patch-update-3086994-5.patch	23.2 KB	sahana _n
#2	deprecated-3086994-2.patch	20.92 KB	sergiu stici

Comments

Comment #1

10 October 2019 at 07:18

Sergiu Stici created an issue. See original summary.

Status	File	Size
new	deprecated-3086994-2.patch	20.92 KB

Comment #3

sahana _n commented 10 October 2019 at 10:45

Status:

Needs review

» Reviewed & tested by the community

Looks good to me. And patch applied successfully.

Comment #4

yce commented 8 November 2019 at 09:24

Status:

Reviewed & tested by the community

» Needs work

Hi, I've reviewed your changes, it still needs some work. Please also make sure that in a method you call a specific method only once, for example $this->messenger() should be stored in a variable in some places to avoid multiple method call for the same thing within the same scope.

+++ b/brightcove.install
@@ -221,9 +221,6 @@ function brightcove_update_8105() {
-  \Drupal::entityDefinitionUpdateManager()->applyUpdates();

Please provide the alternative solution suggested by core.

+++ b/src/BrightcovePlaylistListBuilder.php
@@ -103,7 +102,7 @@ class BrightcovePlaylistListBuilder extends EntityListBuilder {
+      $name = Link::fromTextAndUrl(

Please use the link_generator service instead of calling the link generator in a procedural way.

+++ b/src/BrightcoveUtil.php
@@ -195,30 +195,30 @@ class BrightcoveUtil {
+            \Drupal::messenger()->addWarning(t("There is a newer version of this :type on Brightcove, you may want to <a href=':url'>update the local version</a> before editing it.", [

The messenger is used here in multiple places, please get the messenger once and put it into a variable then used that.

The best would be to use DI, not sure if it would be ok to pass the messenger as the method's argument.

+++ b/src/BrightcoveVideoListBuilder.php
@@ -108,7 +107,7 @@ class BrightcoveVideoListBuilder extends EntityListBuilder {
+      $name = Link::fromTextAndUrl(

Please use the link_generator service instead of calling the link generator in a procedural way.

Comment #5

sahana _n commented 14 November 2019 at 06:44

Status:

Needs work

» Needs review

Status	File	Size
new	Deprecated-Code-patch-update-3086994-5.patch	23.2 KB

Updated the patch please review.

Comment #6

gobinathm

he/him

English

Milton, Ontario

commented 9 February 2021 at 02:42

Issue #3146320 pretty much fixes everything. Maybe we close this in favor of that?

Comment #7

yce commented 18 October 2021 at 09:33

Status:

Needs review

» Fixed

Yes, thanks! Closing the ticket now.

Comment #8

1 November 2021 at 09:34

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Deprecated Code Report

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Related issues

News items

Our community

Documentation

Drupal code base

Governance of community