Module's path conflicts with core Migrate Drupal UI module, change all the paths

Does this show up?

BTW thanks for noticing the path issue on the project page, I fixed it there. It is /admin/reports/upgrade

But it is the same URL /admin/reports/upgrade? or you get redirected? That sounds odd either way.

No there is no redirect to the recent logs at all ever in the module. Can you try this in an absolutely empty site just this module? It should show a list of modules. The data is not collected on cron but rather on the module's own UI, so running cron should not make it any worse or better.

Same thing. CR and cron not helped.

Request:

GET /admin/reports/upgrade HTTP/1.1
Host: lom-ru-8.loc
Connection: keep-alive
Upgrade-Insecure-Requests: 1
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.90 Safari/537.36
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3
Referer: http://lom-ru-8.loc/admin/reports/dblog
Accept-Encoding: gzip, deflate
Accept-Language: ru-RU,ru;q=0.9,en-US;q=0.8,en;q=0.7
Cookie: callme_back_phone=4212271792; SESSedfd3bbb1846f0e0642229508bbd5b9b=iXWaP7FfuhAtkdevUrBf0XL8y7jA0XiWdYlc128JBHM; PLedfd3bbb1846f0e0642229508bbd5b9b=yG8841A4z5EIpOaMYYKfEPOePIspRPuE0xkje7OwpkQ%3A-NhKVcDlNCy8z3hLY9s1vjIskkEgbPCpkQdrBU3B2Ac; region_tid=1646; XDEBUG_SESSION=PHPSTORM

Response:

HTTP/1.1 302 Found
Server: nginx/1.16.1
Content-Type: text/html; charset=UTF-8
Transfer-Encoding: chunked
Connection: keep-alive
Cache-Control: must-revalidate, no-cache, private
Date: Wed, 02 Oct 2019 12:34:21 GMT
Location: http://lom-ru-8.loc/admin/reports/dblog
X-UA-Compatible: IE=edge
Content-language: ru
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
Expires: Sun, 19 Nov 1978 05:00:00 GMT
Vary:
X-Generator: Drupal 8 (https://www.drupal.org)

Ok this is very interesting. At least we have two people reporting the same thing :) can you try on a fresh site? I suspect there may be some contrib module, eg. admin menu enhancer that tries to "fix a wrong URL" so you can get stuff done faster. But it caches too much somewhere.

Maybe this issue is related: Silently set 'version'=NULL if .git-repository does not exists

I just ran into this. I installed a empty db I made on Sept 26 (has migrate_run installed), then `drush updb`, then install upgrade_status with composer. No errors. Navigate to /admin/reports/upgrade and instead get /admin/reports/dblog.

The curious thing is that I tried this a few days ago on the same dev site with what should have been the same empty database. And then I was able view the Upgrade Status page. `drush cr` does not help.
Notice: Undefined index: version in git_deploy_system_info_alter() (line 103 of modules/contrib/git_deploy/git_deploy.module).

So I reinstalled, using drush, standard profile, and got this error when installing upgrade status.

git_deploy_system_info_alter(Array, Object, 'module') (Line: 539)
Drupal\Core\Extension\ModuleHandler->alter('system_info', Array, Object, 'module') (Line: 320)
Drupal\Core\Extension\ExtensionList->doList() (Line: 154)
Drupal\Core\Extension\ModuleExtensionList->doList() (Line: 282)
Drupal\Core\Extension\ExtensionList->getList() (Line: 440)
Drupal\Core\Extension\ExtensionList->recalculatePathnames() (Line: 422)
Drupal\Core\Extension\ExtensionList->getPathnames() (Line: 519)
Drupal\Core\Extension\ExtensionList->getPathname('upgrade_status') (Line: 276)
drupal_get_filename('module', 'upgrade_status') (Line: 310)
drupal_get_path('module', 'upgrade_status') (Line: 712)
Drupal\Core\Config\ConfigInstaller->drupalGetPath('module', 'upgrade_status') (Line: 694)
Drupal\Core\Config\ConfigInstaller->getDefaultConfigDirectory('module', 'upgrade_status') (Line: 493)
Drupal\Core\Config\ConfigInstaller->checkConfigurationToInstall('module', 'upgrade_status') (Line: 132)
Drupal\Core\ProxyClass\Config\ConfigInstaller->checkConfigurationToInstall('module', 'upgrade_status') (Line: 161)
Drupal\Core\Extension\ModuleInstaller->install(Array, 1) (Line: 83)
Drupal\Core\ProxyClass\Extension\ModuleInstaller->install(Array) (Line: 173)
Drupal\system\Form\ModulesListConfirmForm->submitForm(Array, Object)
call_user_func_array(Array, Array) (Line: 112)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 52)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 591)
Drupal\Core\Form\FormBuilder->processForm('system_modules_confirm_form', Array, Object) (Line: 320)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 91)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 694)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

And navigating to admin/reports/upgrade still takes me to the admin/reports/dblog

The contrib modules on the site in all cases, are git_deploy, migrate_run, upgrade_status. And on the last test migrate_run was not installed.

Hi 👋🏻 I am also facing this issue. I think super_romeo Might be on to something here. My site is is nested within the repo. So possibly git_deploy isn’t finding what it needs.

Had this issue as well, disabling admin toolbar and drupal upgrade didn't help, ended up just changing the word 'upgrade' to 'cupgrade' in upgrade_status.routing.yml as a quick fix and that worked, so it looks like something else is grabbing the 'upgrade' path, but searching through my installed contrib, only upgrade_status had '/upgrade' in it at all, so a bit stumped, really.

The migrate_drupal_ui module actually uses the /admin/reports/upgrade path.

The migrate_drupal_ui.log route points to MigrateController::showLog, which sets some session parameters and performs a redirect to the dblog.overview route.

I've created a patch that changes all route suffixes from /upgrade to /upgrade-status to avoid conflicts.

Fix test after change in https://git.drupalcode.org/project/drupal/commit/9293166c2713df8a0d582e5...

Thanks. #17 works.

Ha, great find! We even advise people to use the two modules alongside when testing upgrades to ensure the new code written is still Drupal 9 compatible.

Giving all of you credits because all of you tried to fix this and provided your steps :)

And landed. Thanks all! I'll try to make a release as soon as I can.

Wow! Great find, @robindh! :)