The "show reset link" functionality works properly with the query_string url processor, but not with the pretty paths one.

CommentFileSizeAuthor
#3 show_reset_link_when_pretty_path_is_active-3079451-3.patch543 bytesmonymirza
#2 show_reset_link_do_not_work_when_pretty_path_is_active-3079451-2.patch543 bytesnanak

Comments

nanak created an issue. See original summary.

nanak’s picture

nanak
Primary language French
Location Sarlat-la-Canéda
commented
Status: Active » Needs review
StatusFileSize
new show_reset_link_do_not_work_when_pretty_path_is_active-3079451-2.patch543 bytes

When pretty path is on, the facets_query route parameter is not empty, and the url of the show reset link is the same than the current page.
Emptying this parameter when the url is built seems to fix the issue.

monymirza’s picture

monymirza
Primary language Urdu
Location Islamabad
commented
StatusFileSize
new show_reset_link_when_pretty_path_is_active-3079451-3.patch543 bytes

re-roll dev.

baluertl’s picture

baluertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

@nanak thanks for the patch and @monymirza for rerolling. Now tested, patch solves the problem described. Marking as RTBC.

mellowtothemax’s picture

mellowtothemax commented

Patch works for me too

borisson_ credited andreasderijcke.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

Duplicate of #3154859, ensuring that andreas gets credit here as well.

  • borisson_ committed 9bd8576 on 8.x-1.x authored by monymirza 
    Issue #3079451 by nanak, monymirza, andreasderijcke: "Show reset link"...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented

Note the result of this change as described in #3427723: What is ?facets_query= in the URL? and how to remove?. Should that be addressed, or should we consider this works as designed?