CommentFileSizeAuthor
#13 interdiff_10-13.txt4.16 KBHarish1688
#13 3073556-13.patch3.4 KBHarish1688
#13 Thunder Admin after patch.png24.41 KBHarish1688
#13 Adminimal theme after patch.png20.35 KBHarish1688
#13 Claro admin after patch.png26.78 KBHarish1688
#12 Thunder Admin.png41.32 KBHarish1688
#12 Claro admin.png38.29 KBHarish1688
#12 Adminimal theme.png26.66 KBHarish1688
#11 scheduled_transitions_dropdown_fix_admin_themes_3073556.patch462 bytessnehal-chibde
#11 gin-after.png199.3 KBsnehal-chibde
#11 gin-before.png148.3 KBsnehal-chibde
#11 Thunder-before.png213.74 KBsnehal-chibde
#11 Thunder-after.png213.7 KBsnehal-chibde
#10 3073556-10.patch1.42 KBlendude
#9 3073556-9.patch1.52 KBlendude
#9 interdiff-3073556-6-9.txt870 byteslendude
#7 Screenshot 2020-02-05 at 10.14.21.png12.41 KBlendude
#6 3073556-6.patch1.61 KBidebr
#5 3073556-5-after.png64.74 KBidebr
#5 3073556-5-before.png64.55 KBidebr
#3 3073556-3.patch1.22 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review

Attached patch associates the existing 'Execute transition' text with the dropdown using aria-labelledby attribute.

idebr’s picture

idebr commented
StatusFileSize
new 3073556-3.patch1.22 KB
rp7’s picture

rp7 commented

Is there a specific reason why this is just not a regular form label? (same Q for "on date" text)

idebr’s picture

idebr commented
StatusFileSize
new 3073556-5-before.png64.55 KB
new 3073556-5-after.png64.74 KB

The addition of Claro as a Drupal Core administration theme introduces a new challenge for displaying the form elements. It turns out using default form API elements results in improved visual coherence:

Before:

After:

Attached is a new approach, so no interdiff.

idebr’s picture

idebr commented
StatusFileSize
new 3073556-6.patch1.61 KB
lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
StatusFileSize
new Screenshot 2020-02-05 at 10.14.21.png12.41 KB

Probably the same reason that causes the miss alignment in HEAD, makes #6 look not great in Seven. Don't thinks it's worse than HEAD, just different 'not great'.

Really like how it looks in Claro though. And much cleaner then the #markup with the HTML tags in the translatable string.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs review » Needs work

This is a change from the previous design language where text and form fields were intermixed to appear like an english sentence more than a bunch of form fields on approximately the same horizontal line.

I agree how it looks in Claro is a reasonable direction forward.

We need to ensure this looks fine on both core themes, so NW.

Also, we should make sure the form looks reasonable with a highly used contrib admin theme, such as Adminimal / Thunder / Material Admin.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
StatusFileSize
new interdiff-3073556-6-9.txt870 bytes
new 3073556-9.patch1.52 KB

Just a reroll for now

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Version: 8.x-1.x-dev » 2.x-dev
StatusFileSize
new 3073556-10.patch1.42 KB

Another reroll for 2.x

snehal-chibde’s picture

snehal-chibde commented
Issue summary: View changes
StatusFileSize
new Thunder-after.png213.7 KB
new Thunder-before.png213.74 KB
new gin-before.png148.3 KB
new gin-after.png199.3 KB
new scheduled_transitions_dropdown_fix_admin_themes_3073556.patch462 bytes

hello, we have a duplicate issue created https://www.drupal.org/project/drupal/issues/3383638 under core issues.
I was working on this issue and applied patch #10 and it is still looking off for admin themes like gin, Thunder ( as it was mentioned to check in #8)
It was not fully perfect so after applying patch #10 this is how it looked (see the before screenshots)
Here is my patch to fix the issue in these admin themes and the after screenshots for the same.

Harish1688’s picture

Harish1688 commented
StatusFileSize
new Adminimal theme.png26.66 KB
new Claro admin.png38.29 KB
new Thunder Admin.png41.32 KB

Hi,

Based on your last comments, I tested the patches mentioned in #10 and #11 to resolve the issue. However, I found that the patch in #10 did not resolve the issue for all possible admin themes, as mentioned in comment #8 (Adminimal / Thunder / Claro).

attached the images for reference.

#11 patch not working.

Needs Work

comment #10 patch after:
1. Adminimal
issue image
2. Thunder
issue image
3. Claro
issue image

Harish1688’s picture

Harish1688 commented
StatusFileSize
new Claro admin after patch.png26.78 KB
new Adminimal theme after patch.png20.35 KB
new Thunder Admin after patch.png24.41 KB
new 3073556-13.patch3.4 KB
new interdiff_10-13.txt4.16 KB

Hi,

Tested the patch from #10, #11, both are not working mention in comment #11. so created a patch (3073556-13.patch) to resolved the issue

Needs review.

patch after (3073556-13.patch) :-
1. Adminimal
Only local images are allowed.

2. Thunder
Only local images are allowed.

3. Claro
Only local images are allowed.

Harish1688’s picture

Harish1688 commented
Status: Needs work » Needs review

The last submitted patch, 10: 3073556-10.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 13: 3073556-13.patch, failed testing. View results

shweta__sharma’s picture

shweta__sharma commented
Status: Needs work » Needs review
shweta__sharma’s picture

shweta__sharma commented
Status: Needs review » Needs work

Ignore #17 mistakenly changed the status.