Update from 4.11.4 to 4.13.
CKEditor 4.12.1 fixed an issue affecting a number of users: https://github.com/ckeditor/ckeditor-dev/issues/2813 — editor.insertHtml pollutes editable with empty spans
CKEditor 4.13 is a big release: https://ckeditor.com/blog/CKEditor-4.13-with-Paste-from-Google-Docs-rele... — it affects Drupal at least in the following ways:
- Massively improved pasting from Google Docs — which fixes #2948171: [upstream] CKEditor paste from Google Docs resulting in all-bold text.
- Better selection handling, particularly triple-click for paragraph selection
- https://github.com/ckeditor/ckeditor-dev/issues/3240 allows us to improve Media Embed in Drupal 8.8 core and Entity Embed in contrib: #3064572: Add mask to prevent interaction with embedded media
See also:
#1858210: [meta] Content editing experience follow-ups — in-place editing and WYSIWYG
#1950098: Update CKEditor library to 4.1
#2036253: Update CKEditor library to 4.2
#2039163: Update CKEditor library to 4.4
#2271051: Update CKEditor library to 4.4.4
#2345961: Update CKEditor library to 4.4.5
#2384581: Security: Update CKEditor library to 4.4.6
#2415111: Update CKEditor library to 4.4.7
#2521820: Update CKEditor library to 4.5.3
#2321583: Update CKEditor library to 4.5.5
#2663566: Update CKEditor library to 4.5.7
#2698587: Update CKEditor library to 4.5.8
#2724225: Update CKEditor library to 4.5.9
#2765751: Update CKEditor library to 4.5.10
#2797427: Update CKEditor library to 4.5.11
#2828494: Update CKEditor library to 4.6
#2848215: Update CKEditor library to 4.6.2
#2893566: Update CKEditor library to 4.7.1
#2904142: Update CKEditor library to 4.7.2
#2908864: Update CKEditor library to 4.7.3
#2926932: Update CKEditor library to 4.8.0
#2962330: Update CKEditor library to 4.9.2
#2983516: Update CKEditor library to 4.10.0
#2999691: Update CKEditor library to 4.10.1
#3035933: Update CKEditor to 4.11.3
#3050757: Update CKEditor to 4.11.4
Release notes snippet
CKEditor has been updated from from 4.11.4 to 4.13.0, which includes numerous bugfixes and improvements.
Comment | File | Size | Author |
---|---|---|---|
#25 | 3072382-25.patch | 3.18 MB | Wim Leers |
#25 | interdiff.txt | 393.73 KB | Wim Leers |
#24 | Screen Shot 2019-11-04 at 12.41.06.png | 80.75 KB | lauriii |
#9 | 3072382-9.patch | 3.15 MB | Wim Leers |
#9 | interdiff.txt | 1.43 MB | Wim Leers |
Comments
Comment #2
osopolarComment #3
Wim LeersThat will be Drupal 8.8 at the earliest, since it's a new minor version of CKEditor. Sorry about that!
Comment #4
Wim LeersThanks for creating this issue by the way! Tagging to make sure this happens before Drupal 8.8.0-alpha1 :)
Comment #5
Wim LeersComment #6
Wim LeersComment #7
Wim LeersClosed #2948171: [upstream] CKEditor paste from Google Docs resulting in all-bold text as a duplicate of this.
Comment #8
Wim LeersWorking with the CKEditor team because it seems CKEditor 4.13 contains a bug. Transcript from my message sent to them:
Stay tuned.
Comment #9
Wim LeersUpdating Drupal's
build-config.js
to includepastefromgdocs
.Comment #10
Wim LeersI can confirm that the problem reported in #2948171: [upstream] CKEditor paste from Google Docs resulting in all-bold text is gone as of #9 🥳
Comment #11
Wim LeersThe bug in CKEditor's build process reported in #8 no longer affects us but was confirmed by the CKEditor team: https://github.com/ckeditor/ckeditor4/issues/3521
Comment #12
BramDriesenWoot! Great job!
Comment #13
Wim LeersComment #15
xjmExpanding the RN slightly.
Comment #16
PasqualleWill this be in D8.8? Can we switch back the issue version field?
Comment #20
lauriiiI confirmed that CKEditor was updated correctly by rebuilding the package and comparing the results with
git diff --color-words=.
. Only changes between the results were hashes that are designed to be unique on every build.I checked the CKEditor 4 issue queue for any major regressions and it seems like there's a regression on Excel copy-pasting. I discussed this with @catch and we agreed to commit this to 8.8.0 regardless of the regression to avoid having to do a big CKEditor update in 8.9.0. CKEditor has scheduled a release for the beginning of December so we could update to the CKEditor patch release on 8.8.1.
Committed to 9.0.x, 8.9.x and 8.8.x! Thank you!
Comment #24
lauriiiI noticed that we might have missed some files in the commit:
Comment #25
Wim LeersExcellent catch @lauriii! And interesting that this did not break anything.
Turns out that
git add core/
does not do what I think it does on my system. And I found the root cause:… turns out that some core patch added (a very broken)
.gitignore
to the root of my Drupal, and then it was left there 🙃This is why I was able to do exactly the same as I've done in the more than a dozen past cases where I updated CKEditor, but this time it resulted in a subtly broken patch 🤦♂️
Comment #29
lauriiiThank you! Committed and pushed again. 🤞