Problem/Motivation

This issue has been cleared by the security team to handled in public.

Update from 4.10.1 to CKEditor 4.11.3: https://ckeditor.com/blog/CKEditor-4.10.1-released/

https://ckeditor.com/cke4/release/CKEditor-4.11.0
https://ckeditor.com/cke4/release/CKEditor-4.11.1
https://ckeditor.com/cke4/release/CKEditor-4.11.2
https://ckeditor.com/cke4/release/CKEditor-4.11.3

https://ckeditor.com/blog/CKEditor-4.11-with-emoji-dropdown-and-auto-lin...

Main justification for upgrade would be the security fix, though emojis are cool too! ;-)

See also:

#1858210: [meta] Content editing experience follow-ups — in-place editing and WYSIWYG
#1950098: Update CKEditor library to 4.1
#2036253: Update CKEditor library to 4.2
#2039163: Update CKEditor library to 4.4
#2271051: Update CKEditor library to 4.4.4
#2345961: Update CKEditor library to 4.4.5
#2384581: Security: Update CKEditor library to 4.4.6
#2415111: Update CKEditor library to 4.4.7
#2521820: Update CKEditor library to 4.5.3
#2321583: Update CKEditor library to 4.5.5
#2663566: Update CKEditor library to 4.5.7
#2698587: Update CKEditor library to 4.5.8
#2724225: Update CKEditor library to 4.5.9
#2765751: Update CKEditor library to 4.5.10
#2797427: Update CKEditor library to 4.5.11
#2828494: Update CKEditor library to 4.6
#2848215: Update CKEditor library to 4.6.2
#2893566: Update CKEditor library to 4.7.1
#2904142: Update CKEditor library to 4.7.2
#2908864: Update CKEditor library to 4.7.3
#2926932: Update CKEditor library to 4.8.0
#2962330: Update CKEditor library to 4.9.2
#2983516: Update CKEditor library to 4.10.0
#2999691: Update CKEditor library to 4.10.1

Release notes snippet

CKEditor updated to 4.11.3

Comments

dudleyc created an issue. See original summary.

cilefen’s picture

Title: Update ckeditor to 4.11.1 » Update CKEditor to 4.11.3
Version: 8.6.10 » 8.7.x-dev
Category: Feature request » Task
Status: Active » Needs review
Related issues: +#2966864: Add optional support for CKEditor 5 in D9 so we can remove CKE 4 from Drupal 10, +#2999691: Update CKEditor library to 4.10.1
StatusFileSize
new6.5 MB

I built this from the source code on tag 4.11.3 with sh build.sh -s --leave-js-unminified. It looks like some files had been minified earlier (#2999691-5: Update CKEditor library to 4.10.1).

cilefen’s picture

Issue summary: View changes
cilefen’s picture

StatusFileSize
new3.42 MB

I read the next comment by Wim on #2999691: Update CKEditor library to 4.10.1 and now understand we want minified.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dudleyc’s picture

Patch works for me, thanks!

cilefen’s picture

Version: 8.8.x-dev » 8.7.x-dev

This is allowed in 8.7.x.

cilefen’s picture

wim leers’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: +JavaScript, +8.7.0 release notes
StatusFileSize
new685 bytes
new3.42 MB

though emojis are cool too! ;-)

We won't get that, because it's a separate CKEditor plugin that we don't include in our build.

Fun note: with https://github.com/ckeditor/ckeditor-dev/issues/2478 (in 4.11.0), they finally changed the default to be sane, which we did nearly six years ago, in #1879120-84: Use Drupal-specific image and link plugins — use core dialogs rather than CKEditor dialogs, containing alterable Drupal forms :) We can't remove our own code for this though, because Drupal has its own drupallink CKEditor plugin.

#4 was nearly perfect — thanks! 🙏The only thing that you forgot was to update core.libraries.yml :)

Manually tested, no problems. 👍

alexpott’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed and pushed 3eff3b33d7 to 8.8.x and 2d2a118498 to 8.7.x. Thanks!

  • alexpott committed aae94ed on 8.8.x
    Issue #3035933 by cilefen, Wim Leers: Update CKEditor to 4.11.3
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.