Scanning project draggableviews-8.x-1.2 results in:

An AJAX HTTP error occurred.
HTTP Result Code: 500
Debugging information follows.
Path: /en/batch?id=39769&op=do_nojs&op=do
StatusText: Internal Server Error
ResponseText:

Similar to #3065760: Fail more gracefully when exceptions happen, eg. Uncaught PHPStan\Broker\ClassAutoloadingException with Redirect 8.x-1.3 the problem is likely in the contrib module, however the Upgrade Status check should catch the error and fail gracefully.

I can post in the other issue if you prefer but I didn’t want to clutter it up while you were still working on it.

Comments

waverate created an issue. See original summary.

waverate’s picture

waverate commented
Related issues: +#3067359: Fatal Error Analyzing Code with phpstan

Opened contrib issue #3067359: Fatal Error Analyzing Code with phpstan.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Closed (duplicate)

I would consider this a duplicate of #3065760: Fail more gracefully when exceptions happen, eg. Uncaught PHPStan\Broker\ClassAutoloadingException with Redirect 8.x-1.3, you can try the "fix" there that I was unable to provide a test for and that does not work for non-JS scenarios, but otherwise it was pretty complete. I think this and that needs the same solution.

waverate’s picture

waverate commented
Issue summary: View changes
Status: Closed (duplicate) » Active

Patch #16 from #3065760: Fail more gracefully when exceptions happen, eg. Uncaught PHPStan\Broker\ClassAutoloadingException with Redirect 8.x-1.3 does not catch this error. After applying and checking just draggableviews, I still have this error:

An AJAX HTTP error occurred.
HTTP Result Code: 500
Debugging information follows.
Path: /en/batch?id=39772&op=do_nojs&op=do
StatusText: Internal Server Error
ResponseText: {"status":true,"percentage":-1,"message":"Logged error. Recovering.","label":"Recoverable fatal error in draggableviews."}
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Postponed (maintainer needs more info)

We can keep this issue open if you really want to, but as I said, there will be no activity in this issue as the solution to this one and #3065760: Fail more gracefully when exceptions happen, eg. Uncaught PHPStan\Broker\ClassAutoloadingException with Redirect 8.x-1.3 should be one and the same. The fact that the solution there does not work underlines why it was not yet committed. Instead of arguing about issue statuses, a more effective way to help would be to post your use case there. For your use case a very likely fix on that patch is to add a Status header as part of this recovery code:

+      // Send some pre-baked JSON response to make progress continue.
+      header('Content-Type: text/javascript');

Basically change that to

+      // Send some pre-baked JSON response to make progress continue.
+      http_response_code(200);
+      header('Content-Type: text/javascript');

Trying that and posting that updated patch there in case it covers your use case would be a welcome contribution. Thanks!

waverate’s picture

waverate commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)

@Gábor Hojtsy. Thank you. That worked perfectly.

Patch attached at #19 of #3065760: Fail more gracefully when exceptions happen, eg. Uncaught PHPStan\Broker\ClassAutoloadingException with Redirect 8.x-1.3.