Opened #3067356: Fail gracefully for HTTP result 500 to catch the PHP error.

Upgrade Status error message pasted in linked issue.

I’ll post the phpstan message shortly.

CommentFileSizeAuthor
#3 3067359-phpstan-03.patch557 bytesnicrodgers

Comments

waverate created an issue. See original summary.

waverate’s picture

waverate commented 
[server-1 contrib]$ phpstan analyse draggableviews/
 4/7 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓░░░░░░░░░░░░]  57%PHP Fatal error:  Declaration of Drupal\draggableviews\Plugin\migrate\destination\DraggableViews::fields(?Drupal\migrate\Entity\MigrationInterface $migration = NULL) must be compatible with Drupal\migrate\Plugin\MigrateDestinationInterface::fields(?Drupal\migrate\Plugin\MigrationInterface $migration = NULL) in /var/www/html/drupal/web/modules/contrib/draggableviews/src/Plugin/migrate/destination/DraggableViews.php on line 61
nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
Status: Active » Needs review
StatusFileSize
new 3067359-phpstan-03.patch557 bytes

Here's a patch.

  • iStryker committed 4e75e6d on 8.x-1.x authored by nicrodgers 
    Issue #3067359 by nicrodgers: Fatal Error Analyzing Code with phpstan
istryker’s picture

istryker commented
Status: Needs review » Fixed

Tried to get phpstan working but couldn't get autoloader working.
Entity directory does not exist, but Plugin does. in /core/modules/migrate/src/Plugin/MigrationInterface.php
Committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.