Backport DiskSpace to D7. The basic building blocks landed with #3059742: Backport base readiness checker logic to 7.x, now we need to copy/paste and D7ify things.
Don't use base Filesystem class. See #3063128: Backport FileOwnership and Filesystem as an example.

CommentFileSizeAuthor
#9 3063129-6.patch2.34 KBheddn
#7 3063129-7.patch2.09 KBtatarbj
#6 3063129-6.patch2.1 KBheddn
#6 interdiff_5-6.txt702 bytesheddn
#5 3063129.patch2.1 KBheddn

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Component: Code » Checkers
heddn’s picture

heddn
Primary language English
Location Illinois
commented
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Issue summary: View changes
Status: Postponed » Active
Issue tags: +Novice
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Active » Needs review
StatusFileSize
new 3063129.patch2.1 KB
heddn’s picture

heddn
Primary language English
Location Illinois
commented
StatusFileSize
new interdiff_5-6.txt702 bytes
new 3063129-6.patch2.1 KB
tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
StatusFileSize
new 3063129-7.patch2.09 KB

I'm not sure why the error checker of PHPSapi got removed, but i've just added it back. Apart of it, everything else looks OK for me.

heddn’s picture

heddn
Primary language English
Location Illinois
commented 
+++ b/ReadinessCheckers/ReadinessCheckerManager.php
@@ -23,7 +23,7 @@ class ReadinessCheckerManager {
-    static::$checkers['error'][0][] = 'PhpSapi';
+    static::$checkers['error'][0][] = 'DiskSpace';

This was intentional. I had only placeholdered php sapi in there until we got a proper error. This is the needed proper error.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
StatusFileSize
new 3063129-6.patch2.34 KB

Re-roll of #6.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Reviewed & tested by the community

Tests are passing, about to commit.

  • heddn committed dce1e81 on 7.x-1.x 
    Issue #3063129 by heddn, tatarbj: Backport DiskSpace
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the review @tatarbj.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.