Backport FileOwnership and Filesystem to D7. The basic building blocks landed with #3059742: Backport base readiness checker logic to 7.x, now we need to copy/paste and D7ify things.

CommentFileSizeAuthor
#7 interdiff_6-7.txt954 bytesheddn
#7 3063128-7.patch2.4 KBheddn
#6 3063128-6.patch2.38 KBheddn
#5 3063128.patch2.38 KBheddn

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Component: Code » Checkers
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Assigned: Unassigned » heddn
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Active » Needs review

There are much fewer services in D7, so it doesn't make sense to keep the base class.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
StatusFileSize
new 3063128.patch2.38 KB
heddn’s picture

heddn
Primary language English
Location Illinois
commented
StatusFileSize
new 3063128-6.patch2.38 KB
heddn’s picture

heddn
Primary language English
Location Illinois
commented
StatusFileSize
new 3063128-7.patch2.4 KB
new interdiff_6-7.txt954 bytes
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Assigned: heddn » Unassigned
tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Status: Needs review » Reviewed & tested by the community

This is fine for me.

Still one thing that hurts my eyes a bit, naming the method 'ownerIsScriptUser' i would expect to get a boolean return not a message though :S maybe it could be later a nice refactoring issue ;)

  • heddn committed 7b8e803 on 7.x-1.x 
    Issue #3063128 by heddn, tatarbj: Backport FileOwnership and Filesystem
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the review.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.