Problem/Motivation

Currently this module has a dependency on jQuery. However, jQuery is no longer required for Drupal, and it seems a waste to have to load a big library in order to load the instagram script from a remote url.

Proposed resolution

Add the external script as a library dependency, so it gets loaded when the library is attached.

Remaining tasks

Do it.

User interface changes

None

API changes

None.

Data model changes

None.

Release notes snippet

None.

CommentFileSizeAuthor
#5 3057264-5.patch1.35 KBkim.pepper
#3 media-entity-instagram-3057264-3.patch434 bytesjigish.addweb

Comments

kim.pepper created an issue. See original summary.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Related issues: +#2880690: Entity embed with ckeditor doesn't work

Looks like it is already loaded in media_entity_instagram.libraries.yml but there is an issue with ckeditor

      //TODO: ckeditor integration still doesn't work
      // If the instagram card is being embedded in a CKEditor's iFrame the widgets
      // library might not have been loaded yet.
jigish.addweb’s picture

jigish.addweb commented
Status: Active » Needs review
StatusFileSize
new media-entity-instagram-3057264-3.patch434 bytes

@kim.pepper, please find the patch for the same, hope this will helps you.

Thanks

Status: Needs review » Needs work

The last submitted patch, 3: media-entity-instagram-3057264-3.patch, failed testing. View results

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs work » Needs review
StatusFileSize
new 3057264-5.patch1.35 KB

We have to actually remove the usage of jQuery as well.

Here's something like what I think we need.

Status: Needs review » Needs work

The last submitted patch, 5: 3057264-5.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review

HEAD is failing see #3083313: Fix the failing HEAD

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

We have a green patch so setting it to RTBC.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

I like. Thank you for getting rid of that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.