Review of the 8.x-1.x branch (commit f4dd252):

  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting
    ./logo.svg:                                                        ASCII text, with very long lines, with no line terminators
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
FILE: ...4000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/iu.theme
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 128 | WARNING | Unused variable $menu_name.
--------------------------------------------------------------------------


FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/theme-settings.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
  56 | WARNING | #description values usually have to run through t() for
     |         | translation
 129 | WARNING | Variable $key_exists is undefined.
 130 | WARNING | Variable $key_exists is undefined.
--------------------------------------------------------------------------

Time: 564ms; Memory: 6Mb

This automated report was generated with PAReview.sh, your friendly project application review script.


FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/css/components/progress.css
--------------------------------------------------------------------------
FOUND 37 ERRORS AFFECTING 18 LINES
--------------------------------------------------------------------------
 18 | ERROR | [x] Expected 1 space after colon in style definition; 9
    |       |     found
 24 | ERROR | [ ] Style definition is empty
 24 | ERROR | [ ] Style definitions must end with a semicolon
 24 | ERROR | [x] Expected 1 space after colon in style definition;
    |       |     newline found
 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 25 | ERROR | [ ] No style definition found on line; check for missing
    |       |     colon
 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 26 | ERROR | [ ] No style definition found on line; check for missing
    |       |     colon
 27 | ERROR | [ ] Style definition is empty
 27 | ERROR | [ ] Style definitions must end with a semicolon
 27 | ERROR | [x] Expected 1 space after colon in style definition;
    |       |     newline found
 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 28 | ERROR | [ ] No style definition found on line; check for missing
    |       |     colon
 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 29 | ERROR | [ ] No style definition found on line; check for missing
    |       |     colon
 30 | ERROR | [ ] Style definition is empty
 30 | ERROR | [ ] Style definitions must end with a semicolon
 30 | ERROR | [x] Expected 1 space after colon in style definition;
    |       |     newline found
 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 31 | ERROR | [ ] No style definition found on line; check for missing
    |       |     colon
 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 32 | ERROR | [ ] No style definition found on line; check for missing
    |       |     colon
 55 | ERROR | [x] Opening brace should be the last content on the line
 55 | ERROR | [x] Closing brace of class definition must be on new line
 56 | ERROR | [x] Opening brace should be the last content on the line
 56 | ERROR | [x] Closing brace of class definition must be on new line
 59 | ERROR | [x] Opening brace should be the last content on the line
 59 | ERROR | [x] Closing brace of class definition must be on new line
 60 | ERROR | [x] Opening brace should be the last content on the line
 60 | ERROR | [x] Closing brace of class definition must be on new line
 63 | ERROR | [x] Opening brace should be the last content on the line
 63 | ERROR | [x] Closing brace of class definition must be on new line
 64 | ERROR | [x] Opening brace should be the last content on the line
 64 | ERROR | [x] Closing brace of class definition must be on new line
 65 | ERROR | [x] Expected 1 newline at end of file; 4 found
 68 | ERROR | [ ] More than 2 empty lines are not allowed
 68 | ERROR | [x] Additional whitespace found at end of file
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 24 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../vendor/drupal/pareviewsh/pareview_temp/css/components/is-active.css
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
 60 | ERROR | [ ] Style definitions must end with a semicolon
 63 | ERROR | [x] Expected 1 space before opening brace of class
    |       |     definition; 0 found
 64 | ERROR | [ ] Style definitions must end with a semicolon
 70 | ERROR | [ ] Style definitions must end with a semicolon
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...drupal/pareviewsh/pareview_temp/css/components/filter-alpha-link.css
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 1 | ERROR | [x] Additional whitespace found at start of file
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/css/components/site-alert.css
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 19 | ERROR | [x] CSS colours must be defined in lowercase; expected
    |       |     #7a1705 but found #7A1705
 26 | ERROR | [x] CSS colours must be defined in lowercase; expected
    |       |     #4c1213 but found #4C1213
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/css/components/form.css
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
   1 | ERROR | [x] Additional whitespace found at start of file
 118 | ERROR | [ ] Style definitions must end with a semicolon
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/css/components/ckeditor.css
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 2 | ERROR | [x] Selectors must be on a single line
 3 | ERROR | [x] Blank lines are not allowed between class names
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/css/components/off-canvas.css
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | ERROR | [x] Additional whitespace found at start of file
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...endor/drupal/pareviewsh/pareview_temp/css/components/color-block.css
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] Selectors must be on a single line
  2 | ERROR | [x] Blank lines are not allowed between class names
 38 | ERROR | [x] Each style definition must be on a line by itself
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...00/site1101/web/vendor/drupal/pareviewsh/pareview_temp/css/theme.css
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | ERROR | [x] Additional whitespace found at start of file
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...4000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/iu.theme
--------------------------------------------------------------------------
FOUND 50 ERRORS AFFECTING 31 LINES
--------------------------------------------------------------------------
   1 | ERROR | [x] Missing file doc comment
  40 | ERROR | [x] Expected 1 space before opening brace; found 0
  49 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
  57 | ERROR | [x] Concat operator must be surrounded by a single space
  65 | ERROR | [x] Expected 1 space before opening brace; found 0
 107 | ERROR | [x] Expected 1 space before opening brace; found 0
 114 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
 135 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
     |       |     but found 2 spaces
 170 | ERROR | [x] Expected 1 space before "-"; 0 found
 170 | ERROR | [x] Expected 1 space after "-"; 0 found
 179 | ERROR | [x] Expected 1 space before "-"; 0 found
 179 | ERROR | [x] Expected 1 space after "-"; 0 found
 179 | ERROR | [x] Expected 1 space before "-"; 0 found
 179 | ERROR | [x] Expected 1 space after "-"; 0 found
 200 | ERROR | [ ] Inline doc block comments are not allowed; use "/*
     |       |     Comment */" or "// Comment" instead
 250 | ERROR | [x] Expected 1 space after IF keyword; 0 found
 263 | ERROR | [x] Expected 1 blank line after function; 0 found
 268 | ERROR | [x] No space found before comment text; expected "//
     |       |     var_dump($variables);" but found
     |       |     "//var_dump($variables);"
 308 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
 323 | ERROR | [ ] Doc comment short description must be on a single
     |       |     line, further text should be a separate paragraph
 330 | ERROR | [x] Expected 1 space before "=>"; 0 found
 330 | ERROR | [x] Expected 1 space after "=>"; 0 found
 336 | ERROR | [x] Expected 1 space before "=>"; 0 found
 336 | ERROR | [x] Expected 1 space after "=>"; 0 found
 342 | ERROR | [x] Expected 1 space before "=>"; 0 found
 342 | ERROR | [x] Expected 1 space after "=>"; 0 found
 348 | ERROR | [x] Expected 1 space before "=>"; 0 found
 348 | ERROR | [x] Expected 1 space after "=>"; 0 found
 354 | ERROR | [x] Expected 1 space before "=>"; 0 found
 354 | ERROR | [x] Expected 1 space after "=>"; 0 found
 360 | ERROR | [x] Expected 1 space before "=>"; 0 found
 360 | ERROR | [x] Expected 1 space after "=>"; 0 found
 366 | ERROR | [x] Expected 1 space before "=>"; 0 found
 366 | ERROR | [x] Expected 1 space after "=>"; 0 found
 372 | ERROR | [x] Expected 1 space before "=>"; 0 found
 372 | ERROR | [x] Expected 1 space after "=>"; 0 found
 378 | ERROR | [x] Expected 1 space before "=>"; 0 found
 378 | ERROR | [x] Expected 1 space after "=>"; 0 found
 384 | ERROR | [x] Expected 1 space before "=>"; 0 found
 384 | ERROR | [x] Expected 1 space after "=>"; 0 found
 390 | ERROR | [x] Expected 1 space before "=>"; 0 found
 390 | ERROR | [x] Expected 1 space after "=>"; 0 found
 396 | ERROR | [x] Expected 1 space before "=>"; 0 found
 396 | ERROR | [x] Expected 1 space after "=>"; 0 found
 402 | ERROR | [x] Expected 1 space before "=>"; 0 found
 402 | ERROR | [x] Expected 1 space after "=>"; 0 found
 408 | ERROR | [x] Expected 1 space before "=>"; 0 found
 408 | ERROR | [x] Expected 1 space after "=>"; 0 found
 414 | ERROR | [x] Expected 1 space before "=>"; 0 found
 414 | ERROR | [x] Expected 1 space after "=>"; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 48 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/theme-settings.php
--------------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 7 LINES
--------------------------------------------------------------------------
   1 | ERROR   | [x] The PHP open tag must be followed by exactly one
     |         |     blank line
  25 | ERROR   | [x] Short array syntax must be used to define arrays
  42 | ERROR   | [x] Short array syntax must be used to define arrays
  67 | ERROR   | [x] Short array syntax must be used to define arrays
  81 | ERROR   | [x] Concat operator must be surrounded by a single space
  83 | ERROR   | [x] Concat operator must be surrounded by a single space
  83 | ERROR   | [x] Concat operator must be surrounded by a single space
 117 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: 'campus'
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 2.28 secs; Memory: 6Mb

/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 1, col 1, Error - Expected space or tab after '/*' in comment. (spaced-comment)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 4, col 2, Error - Use the function form of 'use strict'. (strict)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 4, col 10, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 4, col 32, Error - Shadowing of global property 'undefined'. (no-shadow-restricted-names)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 4, col 32, Error - Unexpected use of undefined. (no-undefined)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 5, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 5, col 31, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 7, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 8, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 9, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 11, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 12, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 15, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 17, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 22, col 9, Error - Expected an assignment or function call and instead saw an expression. (no-unused-expressions)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 22, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 25, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 25, col 33, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 28, col 13, Error - Expected indentation of 10 spaces but found 12. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 31, col 13, Error - Expected indentation of 10 spaces but found 12. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 32, col 17, Error - Expected indentation of 14 spaces but found 16. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 35, col 13, Error - Expected indentation of 10 spaces but found 12. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 37, col 17, Error - Expected indentation of 14 spaces but found 16. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 39, col 13, Error - Expected indentation of 10 spaces but found 12. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 43, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 43, col 46, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 44, col 13, Error - Expected indentation of 10 spaces but found 12. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 44, col 17, Error - 'scope' is assigned a value but never used. (no-unused-vars)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 46, col 13, Error - Expected indentation of 10 spaces but found 12. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 46, col 97, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 47, col 17, Error - Expected indentation of 14 spaces but found 16. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 47, col 52, Error - A space is required after ','. (comma-spacing)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 47, col 57, Error - Expected '===' and instead saw '=='. (eqeqeq)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 47, col 87, Error - A space is required after ','. (comma-spacing)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 47, col 113, Error - Expected '===' and instead saw '=='. (eqeqeq)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 48, col 21, Error - Expected indentation of 18 spaces but found 20. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 49, col 21, Error - Expected indentation of 18 spaces but found 20. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 49, col 87, Error - Infix operators must be spaced. (space-infix-ops)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 51, col 21, Error - Expected indentation of 18 spaces but found 20. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 52, col 25, Error - Expected indentation of 22 spaces but found 24. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 53, col 29, Error - Expected indentation of 26 spaces but found 28. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 56, col 25, Error - Expected indentation of 22 spaces but found 24. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 64, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 64, col 41, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 65, col 13, Error - Expected indentation of 10 spaces but found 12. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 65, col 17, Error - 'scope' is assigned a value but never used. (no-unused-vars)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 67, col 13, Error - Expected indentation of 10 spaces but found 12. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 67, col 15, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 67, col 49, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 68, col 17, Error - Expected indentation of 14 spaces but found 16. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 70, col 17, Error - Expected indentation of 14 spaces but found 16. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 71, col 21, Error - Expected indentation of 18 spaces but found 20. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 72, col 25, Error - Expected indentation of 22 spaces but found 24. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 72, col 73, Error - Unexpected trailing comma. (comma-dangle)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 75, col 21, Error - Expected indentation of 18 spaces but found 20. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 75, col 68, Warning - Too many nested callbacks (4). Maximum allowed is 3. (max-nested-callbacks)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 76, col 25, Error - Expected indentation of 22 spaces but found 24. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 79, col 21, Error - Expected indentation of 18 spaces but found 20. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 80, col 25, Error - Expected indentation of 22 spaces but found 24. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 80, col 27, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 81, col 25, Error - Expected indentation of 22 spaces but found 24. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 83, col 21, Error - Expected indentation of 18 spaces but found 20. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 83, col 92, Error - There should be no spaces inside this paren. (space-in-parens)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 84, col 25, Error - Expected indentation of 22 spaces but found 24. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/init.js: line 85, col 25, Error - Expected indentation of 22 spaces but found 24. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/tabledrag.js: line 1, col 2, Error - Use the function form of 'use strict'. (strict)

66 problems
CommentFileSizeAuthor
#14 3053802-12-13-interdiff.txt1.09 KBjwilson3
#14 3053802-13.patch7.12 KBjwilson3
#13 3053802-9.patch6.3 KBjwilson3
#13 3053802-12.patch7.16 KBjwilson3
#7 3053802-7.patch27.75 KBjwilson3
#2 3053802-2.patch2.87 KBsourabhjain

Comments

jwilson3 created an issue. See original summary.

sourabhjain’s picture

sourabhjain
Primary language English
commented
StatusFileSize
new 3053802-2.patch2.87 KB

Resolved the code sniffer issue.

sourabhjain’s picture

sourabhjain
Primary language English
commented
Status: Active » Needs review
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Needs review » Reviewed & tested by the community

Looks good. Merging thank you.

  • jwilson3 committed 6cf6621 on 8.x-1.x 
    Issue #3053802 by sourabhjain: Pass Coding Standards (PAReview)
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Reviewed & tested by the community » Needs work

There were still several errors that werent fixed here.

❯ coder/vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml iu

FILE: /Users/jameswilson/App/Contrib/iu/css/theme.css
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
  1 | ERROR | [x] Additional whitespace found at start of file
 29 | ERROR | [x] Multiple selectors should each be on a single line
 29 | ERROR | [x] Multiple selectors should each be on a single line
 33 | ERROR | [x] Multiple selectors should each be on a single line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /Users/jameswilson/App/Contrib/iu/css/components/site-alert.css
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
 26 | ERROR | [x] CSS colours must be defined in lowercase; expected #7a1705 but found #7A1705
-----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------


FILE: /Users/jameswilson/App/Contrib/iu/css/components/off-canvas.css
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 1 | ERROR | [x] Additional whitespace found at start of file
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /Users/jameswilson/App/Contrib/iu/css/components/progress.css
----------------------------------------------------------------------------------
FOUND 34 ERRORS AFFECTING 18 LINES
----------------------------------------------------------------------------------
 18 | ERROR | [x] Expected 1 space after colon in style definition; 9 found
 24 | ERROR | [ ] Style definition is empty
 24 | ERROR | [x] Expected 1 space after colon in style definition; newline found
 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 25 | ERROR | [ ] No style definition found on line; check for missing colon
 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 26 | ERROR | [ ] No style definition found on line; check for missing colon
 27 | ERROR | [ ] Style definition is empty
 27 | ERROR | [x] Expected 1 space after colon in style definition; newline found
 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 28 | ERROR | [ ] No style definition found on line; check for missing colon
 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 29 | ERROR | [ ] No style definition found on line; check for missing colon
 30 | ERROR | [ ] Style definition is empty
 30 | ERROR | [x] Expected 1 space after colon in style definition; newline found
 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 31 | ERROR | [ ] No style definition found on line; check for missing colon
 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 32 | ERROR | [ ] No style definition found on line; check for missing colon
 55 | ERROR | [x] Opening brace should be the last content on the line
 55 | ERROR | [x] Closing brace of class definition must be on new line
 56 | ERROR | [x] Opening brace should be the last content on the line
 56 | ERROR | [x] Closing brace of class definition must be on new line
 59 | ERROR | [x] Opening brace should be the last content on the line
 59 | ERROR | [x] Closing brace of class definition must be on new line
 60 | ERROR | [x] Opening brace should be the last content on the line
 60 | ERROR | [x] Closing brace of class definition must be on new line
 63 | ERROR | [x] Opening brace should be the last content on the line
 63 | ERROR | [x] Closing brace of class definition must be on new line
 64 | ERROR | [x] Opening brace should be the last content on the line
 64 | ERROR | [x] Closing brace of class definition must be on new line
 65 | ERROR | [x] Expected 1 newline at end of file; 4 found
 68 | ERROR | [ ] More than 2 empty lines are not allowed
 68 | ERROR | [x] Additional whitespace found at end of file
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 24 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------


FILE: /Users/jameswilson/App/Contrib/iu/css/components/color-block.css
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
  1 | ERROR | [x] Selectors must be on a single line
  2 | ERROR | [x] Blank lines are not allowed between class names
 38 | ERROR | [x] Each style definition must be on a line by itself
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /Users/jameswilson/App/Contrib/iu/css/components/ckeditor.css
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 2 | ERROR | [x] Selectors must be on a single line
 3 | ERROR | [x] Blank lines are not allowed between class names
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /Users/jameswilson/App/Contrib/iu/css/components/form.css
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
   1 | ERROR | [x] Additional whitespace found at start of file
 118 | ERROR | [ ] Style definitions must end with a semicolon
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /Users/jameswilson/App/Contrib/iu/css/components/is-active.css
-------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------
 60 | ERROR | [ ] Style definitions must end with a semicolon
 63 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
 64 | ERROR | [ ] Style definitions must end with a semicolon
 70 | ERROR | [ ] Style definitions must end with a semicolon
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------


FILE: /Users/jameswilson/App/Contrib/iu/css/components/filter-alpha-link.css
----------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------------
 1 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 1 | ERROR | [x] Additional whitespace found at start of file
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------


FILE: /Users/jameswilson/App/Contrib/iu/iu.theme
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 54 ERRORS AND 1 WARNING AFFECTING 34 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] Missing file doc comment
  16 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  61 | ERROR   | [x] Expected 1 space before opening brace; found 0
  70 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  78 | ERROR   | [x] Concat operator must be surrounded by a single space
  86 | ERROR   | [x] Expected 1 space before opening brace; found 0
 102 | ERROR   | [ ] The array declaration extends to column 95 (the limit is 80). The array content should be split up over multiple lines
 128 | ERROR   | [x] Expected 1 space before opening brace; found 0
 135 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 156 | ERROR   | [x] Equals sign not aligned correctly; expected 1 space but found 2 spaces
 191 | ERROR   | [x] Expected 1 space before "-"; 0 found
 191 | ERROR   | [x] Expected 1 space after "-"; 0 found
 200 | ERROR   | [x] Expected 1 space before "-"; 0 found
 200 | ERROR   | [x] Expected 1 space after "-"; 0 found
 200 | ERROR   | [x] Expected 1 space before "-"; 0 found
 200 | ERROR   | [x] Expected 1 space after "-"; 0 found
 221 | WARNING | [x] The variable name should be defined after the type
 271 | ERROR   | [x] Expected 1 space after IF keyword; 0 found
 284 | ERROR   | [x] Expected 1 blank line after function; 0 found
 289 | ERROR   | [x] No space found before comment text; expected "// var_dump($variables);" but found "//var_dump($variables);"
 329 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 365 | ERROR   | [x] Expected 1 space after comma in argument list; 2 found
 365 | ERROR   | [x] Expected one space after the comma, 2 found
 365 | ERROR   | [x] Short array syntax must be used to define arrays
 370 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 377 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 377 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 383 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 383 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 389 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 389 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 395 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 395 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 401 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 401 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 407 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 407 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 413 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 413 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 419 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 419 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 425 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 425 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 431 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 431 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 437 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 437 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 443 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 443 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 449 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 449 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 455 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 455 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 461 | ERROR   | [x] Expected 1 space before "=>"; 0 found
 461 | ERROR   | [x] Expected 1 space after "=>"; 0 found
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 53 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------

Time: 293ms; Memory: 12MB
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Needs work » Needs review
StatusFileSize
new 3053802-7.patch27.75 KB

  • jwilson3 committed f7e3b6f on 8.x-1.x 
    Issue #3053802 by jwilson3: Pass Coding Standards (phpcs)
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Needs review » Fixed

There are two remaining errors but these are false positives, and should be ignored:

❯ coder/vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml iu

FILE: /Users/jameswilson/App/Contrib/iu/css/components/color-block.css
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 1 | ERROR | [x] Selectors must be on a single line
 2 | ERROR | [x] Blank lines are not allowed between class names
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /Users/jameswilson/App/Contrib/iu/css/components/ckeditor.css
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 2 | ERROR | [x] Selectors must be on a single line
 3 | ERROR | [x] Blank lines are not allowed between class names
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 214ms; Memory: 12MB
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Fixed » Needs work

There are still additional fixes needed to pass PAReview.

  • jwilson3 committed f4f9f7e on 8.x-1.x 
    Issue #3053802 by jwilson3: Pass Coding Standards (PAReview)
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

There are still fixes needed for ESlint:

❯ npx eslint web/themes/contrib
Warning: React version was set to "detect" in eslint-plugin-react settings, but the "react" package is not installed. Assuming latest React version for linting.

/Users/jameswilson/App/IULD8/web/themes/contrib/iu/js/init.js
   4:2   warning  Unexpected unnamed function                                            func-names
   4:33  error    Shadowing of global property 'undefined'                               no-shadow-restricted-names
   4:33  warning  'undefined' is defined but never used                                  no-unused-vars
   5:21  warning  Unexpected unnamed function                                            func-names
   6:5   error    'Foundation' is not defined                                            no-undef
   7:5   error    'Foundation' is not defined                                            no-undef
   8:5   error    'Foundation' is not defined                                            no-undef
  10:5   error    'Foundation' is not defined                                            no-undef
  11:5   error    'Foundation' is not defined                                            no-undef
  21:5   error    Expected an assignment or function call and instead saw an expression  no-unused-expressions
  24:21  warning  Unexpected unnamed function                                            func-names
  43:34  warning  Unexpected unnamed function                                            func-names
  44:13  warning  'scope' is assigned a value but never used                             no-unused-vars
  48:16  warning  Unexpected unnamed function                                            func-names
  50:13  error    Unexpected use of 'location'                                           no-restricted-globals
  50:50  error    Expected '===' and instead saw '=='                                    eqeqeq
  52:13  error    Unexpected use of 'location'                                           no-restricted-globals
  52:31  error    Expected '===' and instead saw '=='                                    eqeqeq
  72:29  warning  Unexpected unnamed function                                            func-names
  73:13  warning  'scope' is assigned a value but never used                             no-unused-vars
  75:35  warning  Unexpected unnamed function                                            func-names
  75:45  warning  'event' is defined but never used                                      no-unused-vars
  88:34  warning  Too many nested callbacks (4). Maximum allowed is 3                    max-nested-callbacks
  88:34  warning  Unexpected unnamed function                                            func-names

/Users/jameswilson/App/IULD8/web/themes/contrib/iu/js/tabledrag.js
  1:2   warning  Unexpected unnamed function                                                                                                                                                                                                                                                                                                                                                                                       func-names
  1:23  warning  'drupalSettings' is defined but never used                                                                                                                                                                                                                                                                                                                                                                        no-unused-vars
  2:1   error    Delete `⏎`                                                                                                                                                                                                                                                                                                                                                                                                        prettier/prettier
  5:14  error    Replace `'<div·class="tabledrag-changed-warning·alert·message"·role="alert">'·+·Drupal.theme('tableDragChangedMarker')·+·'·'·+·Drupal.t('You·have·unsaved·changes.')·+·'</div>'` with `(⏎········'<div·class="tabledrag-changed-warning·alert·message"·role="alert">'·+⏎········Drupal.theme("tableDragChangedMarker")·+⏎········"·"·+⏎········Drupal.t("You·have·unsaved·changes.")·+⏎········"</div>"⏎······)`  prettier/prettier
  5:14  error    Unexpected string concatenation                                                                                                                                                                                                                                                                                                                                                                                   prefer-template
  6:6   error    Insert `,`                                                                                                                                                                                                                                                                                                                                                                                                        prettier/prettier
  7:6   error    Delete `⏎`                                                                                                                                                                                                                                                                                                                                                                                                        prettier/prettier

✖ 31 problems (16 errors, 15 warnings)
  5 errors and 0 warnings potentially fixable with the `--fix` option.
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Needs work » Needs review
StatusFileSize
new 3053802-12.patch7.16 KB
new 3053802-9.patch6.3 KB

Patches for #9 addresses PAReview output and this patch for #12 addresses ESlint errors.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
StatusFileSize
new 3053802-13.patch7.12 KB
new 3053802-12-13-interdiff.txt1.09 KB

Patch in #12 had some issues in JS console:

jquery.min.js?v=3.5.1:2 jQuery.Deferred exception: Cannot read properties of undefined (reading 'OffCanvas') TypeError: Cannot read properties of undefined (reading 'OffCanvas')
    at HTMLDocument.initializeIUFrameworkJavascript (http://iuld8.ddev.site/themes/contrib/iu/js/init.js?r11ovp:7:16)
    at e (http://iuld8.ddev.site/core/assets/vendor/jquery/jquery.min.js?v=3.5.1:2:30005)
    at t (http://iuld8.ddev.site/core/assets/vendor/jquery/jquery.min.js?v=3.5.1:2:30307) undefined

jquery.min.js?v=3.5.1:2 Uncaught TypeError: Cannot read properties of undefined (reading 'OffCanvas')
    at HTMLDocument.initializeIUFrameworkJavascript (init.js?r11ovp:7)
    at e (jquery.min.js?v=3.5.1:2)
    at t (jquery.min.js?v=3.5.1:2)

This patch solves this issue.

  • jwilson3 committed 3474c33 on 8.x-1.x 
    Issue #3053802 by jwilson3: Pass Coding Standards (eslint)
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.