Hi! I've noticed error $(...).size is not a function on panel's edit page using jQuery 3.1 for admin pages.

CommentFileSizeAuthor
#6 ctools-fix-errors-using-jquery3-3053419-2.patch822 byteskhiminrm
#2 ctools-fix-errors-using-jquery3-3053419.patch1.61 KBkhiminrm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

khiminrm created an issue. See original summary.

khiminrm’s picture

khiminrm CreditAttribution: khiminrm at Lemberg Solutions commented
FileSize
ctools-fix-errors-using-jquery3-3053419.patch1.61 KB
khiminrm’s picture

khiminrm CreditAttribution: khiminrm at Lemberg Solutions commented
Status: Active » Needs review
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Version: 7.x-1.15 » 7.x-1.x-dev
Status: Needs review » Fixed

Thanks @khiminrm 👍, that didn't quite apply to the latest dev branch but I fuzzed it and committed that to the latest dev branch. All our fixes are made against the dev branch for future patches.

Thanks for finding that.

khiminrm’s picture

khiminrm CreditAttribution: khiminrm at Lemberg Solutions commented
FileSize
ctools-fix-errors-using-jquery3-3053419-2.patch822 bytes

Thanks @joelpittet!
Indeed was problem with patch - duplicated lines. I've just noticed it.
I've upload new file if someone will need correct patch file for 1.15

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Parent issue: » #3031732: Plan for CTools 7.x-1.16 release
ron_s’s picture

ron_s CreditAttribution: ron_s commented
Related issues: +#3178516: Recent patch causes JavaScript to be broken

This patch includes incorrectly formatted JavaScript which causes CTools 7.x-1.16 to be broken.

See:
https://www.drupal.org/project/ctools/issues/3178516
https://www.drupal.org/project/ctools/issues/3123734