Drupal 9 Deprecated Code Report

Better decision for drupal_set_message() replacement.

Add the replace of deprecated drupal_realpath().

Waw, the patch is ready! :)

error: patch failed: src/Filter/DrupalUtils.php:98
error: src/Filter/DrupalUtils.php: patch does not apply

I re-rolled it.

I fixed:

------ ---------------------------------------------------------------------------------------- 
  Line   lib/backup_migrate_core/src/Destination/DirectoryDestination.php                        
 ------ ---------------------------------------------------------------------------------------- 
  248    Call to deprecated method uriScheme() of class Drupal\Core\File\FileSystemInterface:    
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use                                   
         Drupal\Core\StreamWrapper\StreamWrapperManagerInterface::getScheme()                    
         instead.                                                                                
  251    Call to deprecated method validScheme() of class Drupal\Core\File\FileSystemInterface:  
         in drupal:8.0.0 and is removed from drupal:9.0.0. Use                                   
         Drupal\Core\StreamWrapper\StreamWrapperManagerInterface::isValidScheme()                
         instead.                                                                                
 ------ ---------------------------------------------------------------------------------------- 

We still need to work on:

------ ---------------------------------------------------------------------------------- 
  Line   backup_migrate.module                                                             
 ------ ---------------------------------------------------------------------------------- 
  25     Instantiation of deprecated class Symfony\Component\ClassLoader\Psr4ClassLoader:  
         since version 3.3, to be removed in 4.0.                                          
 ------ ---------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   lib/backup_migrate_core/src/Service/HTTPClientInterface.php                                                                                       
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------- 
         Class BackupMigrate\Core\Service\HttpClientInterface was not found while trying to analyse it - autoloading is probably not configured properly.  
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------- 
  Line   lib/backup_migrate_core/src/Service/PhpCurlHttpClient.php                                    
 ------ --------------------------------------------------------------------------------------------- 
  13     Class BackupMigrate\Core\Service\HttpClientInterface not found and could not be autoloaded.  
 ------ --------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------- 
  Line   src/Environment/DrupalEnvironment.php                                                        
 ------ --------------------------------------------------------------------------------------------- 
         Class BackupMigrate\Core\Environment\EnvironmentBase not found and could not be autoloaded.  
 ------ --------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------- 
  Line   tests/src/Functional/BackupMigrateEnablingTest.php                         
 ------ --------------------------------------------------------------------------- 
         Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.  
 ------ --------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------- 
  Line   tests/src/Functional/BackupMigratePageLoadTest.php                         
 ------ --------------------------------------------------------------------------- 
         Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.  
 ------ --------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------- 
  Line   tests/src/Functional/BackupMigratePermissionsTest.php                      
 ------ --------------------------------------------------------------------------- 
         Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.  
 ------ --------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------- 
  Line   tests/src/Functional/BackupMigrateQuickBackupTest.php                      
 ------ --------------------------------------------------------------------------- 
         Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.  
 ------ --------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 8 errors  

I'm little confused on how to help out on the "deprecated issues of B&M".
The following D9 Plan for B&M indicates that:

Start fixing 9.x compatibility bugs in sub-issues, not in this one.

https://www.drupal.org/project/backup_migrate/issues/3092547

Which i think means: one child issue per deprecation OR per-file-to-be-fixed.
However, it looks like from this thread that one BIG patch is being updated.

The advantage of "one child issue per deprecation-error OR per file-to-be-fixed " is:

-its easier to see what's left from the deprecation errors.
-easier to commit/maintain since its one item/one file etc.

Please let me know if I'm wrong. I will wait a little and then work as indicated above.

Let's get this into the next release.

This example might help: https://www.php-fig.org/psr/psr-4/examples/

This includes some additional cleanup.

Working on fixing the errors.

WIP.

I've come to realize that a) we can merge the 3rd party library into the main codebase, b) doing so would be a massive API change and so would require a new branch.

So we'll fix the smaller issues here but will then have to do a new branch to finish the D9 compatibility changes. At that point we should also consider refactoring much of the API to get rid of the unnecessary layers.

This should fix one of the last bugs.

The last bug seems to be because the backup tries to happen before the private storage system is configured and the APIs aren't detecting the problem.

Also need to roll back some of the unnecessary code changes, those should be done separately.

This moves the custom library into the main src/Core directory, moves some things from src into src/Drupal and updates things to suit; it worked locally, so we'll see if the tests are ok.

Solved! There was a line in src/Core/Destination/DirectoryDestination.php that needed to use getSchema() instead of isValidSchema().

Updated composer.json file.

Some improvements to README.txt and composer.json, so I'm not going to rerun the tests.

Trying to fix the D9 test failures.

Ok, manually testing it on D9.0 runs into problems, so it isn't going to be committed today :-\

The D9 errors are mostly related to a missing "config_export" item in the annotations.

Also, drupal-check reported this:

 ------ ----------------------------------------------------------------------------------------------------- 
  Line   src/Drupal/Environment/DrupalEnvironment.php                                                         
 ------ ----------------------------------------------------------------------------------------------------- 
         Class Drupal\backup_migrate\Core\Environment\EnvironmentBase not found and could not be autoloaded.  
  12     Class Drupal\backup_migrate\Core\Environment\EnvironmentBase not found and could not be autoloaded.  
 ------ ----------------------------------------------------------------------------------------------------- 

The DrupalEnvironment class seemed to part of something that was planned but never finished, so let's just get rid of it.

This also adds the missing "config_export" items.

One bug left..

Let's see if this solves the last problem.

This appears to fix the @dataProvider syntax, let's hope it works correctly now.

THE TESTS ARE GREEN ON D9! WOOHOO!!

Committed.

Further work will be done in other tickets.

https://www.drupal.org/project/backup_migrate/issues/3051092#comment-136... works for me.

Thanks