[D8] Mobile Device Detection

Thanks for your contribution!

• Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: ...l-8/modules/mobile_device_detection/mobile_device_detection.info.yml
  --------------------------------------------------------------------------
  FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
  --------------------------------------------------------------------------
   1 | WARNING | Remove "datestamp" from the info file, it will be added by
     |         | drupal.org packaging automatically
  --------------------------------------------------------------------------
  

• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: ...modules/mobile_device_detection/src/Object/MobileDeviceDetection.php
  --------------------------------------------------------------------------
  FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
  --------------------------------------------------------------------------
   59 | WARNING | \Drupal calls should be avoided in classes, use
      |         | dependency injection instead
   60 | WARNING | \Drupal calls should be avoided in classes, use
      |         | dependency injection instead
  --------------------------------------------------------------------------
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual review:
* mobile_device_detection.services.yml: all services that your module provides must be prefixed with the module name.
* MobileDeviceDetection: all the {@inheritdoc} comments are wrong because your class those not extend another class or implement an interface.
* $this->setCloudHeaders(): Expected 1 arguments. Found 0.
* "$entity = \Drupal::service('object.mdd');": $entity is not a good name here because that is usually used for nodes, users, terms etc in Drupal. You are getting your service, so maybe $detection_service?
* MobileDeviceDetectionExtenderPlugin: doc block is wrong, this class does something.

Otherwise looks good to me, did not see security issues.

The Git commits are not connected to your user account. You need to specify an email address. See https://www.drupal.org/node/1022156 and https://www.drupal.org/node/1051722

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

You need to edit the project to opt into security coverage (https://www.drupal.org/node/3049879/edit) and set a recommended major version (https://www.drupal.org/node/3049879/edit/releases) which is now set to None.