In #2670454: Deprecate individual schema install of system module in KernelTestBase the special casing of the schema install of the system module which was common in the early years of D8 was deprecated. The change record for this is https://www.drupal.org/node/3003360 but the deprecation message links to an unrelated issue.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3049938-2.patch | 1.15 KB | pfrenssen |
Comments
Comment #2
pfrenssenComment #3
cilefen commentedI am tagging this Novice for the review.
Comment #4
iuana commentedComment #5
iuana commentedI have applied the patch successfully.
Comment #6
iuana commentedComment #7
shashikant_chauhan commentedPatch applies successfully. Updating issue status.
Comment #8
cilefen commentedThe test system ensures patches apply successfully. What we need in a review is affirmation that the change is correct and in scope.
Comment #9
idebr commentedClosed my own #3050363: Fix the node reference in to the deprecation notice for 2670454 as a duplicate. RTBC++
Comment #10
idebr commentedComment #11
iuana commentedThe https://www.drupal.org/node/3003360 is the real change record link for the deprecation.
Comment #12
larowlanCommitted fb532b0 and pushed to 8.8.x. Thanks!
Comment #14
idebr commented@larowlan Can this be backported to 8.7.x since the deprecation was introduced in this branch? This is the release branch most developers will be replacing their code, so it would improve the DX if the deprecation error pointed to the correct change record.
Comment #15
larowlan8.7.x is in freeze for the 8.7.0 release, but yes, after that is lifted it is eligible for backport
Comment #16
pfrenssen8.7.x is unfreezed so this can be done now. I just checked and the patch from #2 applies cleanly on 8.7.x.
Comment #17
larowlanThanks