In #2670454: Deprecate individual schema install of system module in KernelTestBase the special casing of the schema install of the system module which was common in the early years of D8 was deprecated. The change record for this is https://www.drupal.org/node/3003360 but the deprecation message links to an unrelated issue.

CommentFileSizeAuthor
#2 3049938-2.patch1.15 KBpfrenssen

Comments

pfrenssen created an issue. See original summary.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Active » Needs review
StatusFileSize
new 3049938-2.patch1.15 KB
cilefen’s picture

cilefen commented
Issue tags: +Novice, +Documentation

I am tagging this Novice for the review.

iuana’s picture

iuana commented
Assigned: Unassigned » iuana
iuana’s picture

iuana commented

I have applied the patch successfully.

iuana’s picture

iuana commented
Assigned: iuana » Unassigned
shashikant_chauhan’s picture

shashikant_chauhan commented
Status: Needs review » Reviewed & tested by the community

Patch applies successfully. Updating issue status.

cilefen’s picture

cilefen commented

The test system ensures patches apply successfully. What we need in a review is affirmation that the change is correct and in scope.

idebr’s picture

idebr commented

Closed my own #3050363: Fix the node reference in to the deprecation notice for 2670454 as a duplicate. RTBC++

idebr’s picture

idebr commented
Issue tags: +@deprecated
iuana’s picture

iuana commented

The https://www.drupal.org/node/3003360 is the real change record link for the deprecation.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed fb532b0 and pushed to 8.8.x. Thanks!

  • larowlan committed fb532b0 on 8.8.x 
    Issue #3049938 by pfrenssen: Deprecation message linking to wrong change...
idebr’s picture

idebr commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Fixed » Reviewed & tested by the community

@larowlan Can this be backported to 8.7.x since the deprecation was introduced in this branch? This is the release branch most developers will be replacing their code, so it would improve the DX if the deprecation error pointed to the correct change record.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

8.7.x is in freeze for the 8.7.0 release, but yes, after that is lifted it is eligible for backport

pfrenssen’s picture

pfrenssen
Location Sofia
commented

8.7.x is unfreezed so this can be done now. I just checked and the patch from #2 applies cleanly on 8.7.x.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Thanks

  • larowlan committed e82ff71 on 8.7.x 
    Issue #3049938 by pfrenssen: Deprecation message linking to wrong change...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.