If you don't have a mail.css, and a stylesheet in the default page styles doesn't exist, you'll get a PHP error when sending a page. (For instance, the render/sifr module currently attempts to include a non-existent css.)

The fix for this is to add an @ before file_get_contents in theme_mimemail_message:

$output .= @file_get_contents($style);

A patch is attached.

CommentFileSizeAuthor
#8 mimemail.304476_03.patch1.56 KBsgabe
#7 mimemail.304476_02.patch1.59 KBsgabe
#6 mimemail.304476_01.patch1.49 KBsgabe
#3 304476-3.patch1.45 KBThomas_Zahreddin
file_get_contents.patch1.98 KBaaron

Comments

jerdavis’s picture

jerdavis
Location Minneapolis, MN
commented
Status: Needs review » Fixed

Addressed this with a file_exists() check when including each $style. Committed to HEAD in http://drupal.org/cvs?commit=141349

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

Thomas_Zahreddin’s picture

Thomas_Zahreddin commented
Version: 7.x-1.x-dev » 5.x-1.0
Status: Closed (fixed) » Needs review
StatusFileSize
new 304476-3.patch1.45 KB

Hi,

i ran into the same issue.

Have you ever since march 2008 thought about a 5.x-1.1 Version of the module??

Old error are wasting peoples time.

patch is done against 5.x-1.0 Version of mimemail

Thomas_Zahreddin’s picture

Thomas_Zahreddin commented
Status: Needs review » Needs work

Very similar problem in /mimemail/theme/mimemail.theme.inc Version DRUPAL-6--1-0-ALPHA1 in Line 42/43 .

Thomas_Zahreddin’s picture

Thomas_Zahreddin commented
Version: 5.x-1.0 » 6.x-1.0-alpha1

Very similar problem in /mimemail/theme/mimemail.theme.inc Version DRUPAL-6--1-0-ALPHA1 in Line 42/43 .

sgabe’s picture

sgabe commented
Status: Needs work » Needs review
StatusFileSize
new mimemail.304476_01.patch1.49 KB

Patch attached for the current 6.x-1.0-alpha1 release.

sgabe’s picture

sgabe commented
StatusFileSize
new mimemail.304476_02.patch1.59 KB

Attaching a revised version of the patch.

There was a wrong parameter in the preg_replace() function. We can't use path_to_theme() and other similar magic here, because that will break this functionality when CSS optimizing is enabled on the site. This issue isn't addressed to solve the styling problem anyway.

sgabe’s picture

sgabe commented
Version: 6.x-1.0-alpha1 » 7.x-1.x-dev
StatusFileSize
new mimemail.304476_03.patch1.56 KB

Attaching patch against current HEAD.

sgabe’s picture

sgabe commented
Status: Needs review » Fixed

Committed to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.