Hello,
when for a content type new core layout builder is activated, all the field groups aren't displayed.
Only the fields inside the field group are rendered.
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | add-form-layout-hooks.3044595.20.patch | 1.36 KB | adriancid |
Hello,
when for a content type new core layout builder is activated, all the field groups aren't displayed.
Only the fields inside the field group are rendered.
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | add-form-layout-hooks.3044595.20.patch | 1.36 KB | adriancid |
Comments
Comment #2
simePlease confirm this against the latest development version, as there are layout builder bugs that have been fixed.
Comment #3
p4trizio commentedI can confirm this issue even with latest development version
Comment #4
matt_paz commentedAlso confirming that latest dev doesn't seem to work with 8.7 LB
Comment #5
matt_paz commented> Please confirm this against the latest development version, as there are layout builder bugs that have been fixed.
In addition to testing with 8.7.1 LB, I went back and took a look at some of the prior commits.
I could find some that reference layouts, but not layout builder.
I couldn't see where any layouts were defined (ala layouts.yml) nor anything anything that uses Drupal\Core\Layout\LayoutDefault
In field_group_field_ui_form_params I did find this ...
... but that was all I noticed.
This led me to reframe this as a prospective feature request for compatibility with Layout Builder, but if I'm mistaken, please update accordingly.
Comment #6
matt_paz commentedComment #7
seanbI can confirm updating to the latest dev version fixed the issue for me. Thanks!
Comment #8
matt_paz commented@seanB - Any chance you could provide a screenshot of field_group working with layout_builder?
I'm unable to use to configure any field groups from layout_builder using Drupal 8.7.3 and latest field_group 3.x-dev (b245b85f99c48221edf5fb60344dfe53737ae0f9).
Comment #9
matt_paz commentedComment #10
matt_paz commentedI went back and reviewed the work in #2878359 too.
Not sure if other layout related commits made to dev, but it seems like work was only pursued to co-exist with field layout, but not layout builder.
I hope that helps clarify the original request, but let me know if I'm mistaken.
Comment #11
matt_paz commentedJust ran across a potentially interesting work around in #layouts in slack.
- via nord102
It sounds like some folks are using LB on the default/full display, but then adding a different display to load the same node in a block with a conventional display (at which point I think field_group should load LB just fine). Folks are using it to control layout for a select group of fields, while leveraging the power of LB for additional content. I wonder about performance/overhead, but in theory, this might yield a prospective solution that gets the best of both worlds.
Comment #12
AndyThornton commentedHi. I am trying to use Field Group on the backend, to group fields on my Layout Builder blocks forms to make life easier for editors. I realize it might be hard to say, but ... does this bug feel like an existential issue for Field Group? It doesnt seem like Field Group is even getting a look in, as the HTML of the front just looks like it would if FG wasn't enabled.
Comment #13
epicflux commentedHere's a patch to get field groups to show up on the Layout Builder add/update block forms.
Comment #14
epicflux commentedAdjusting the patch to avoid errors with non-custom block types.
Comment #15
philosurfer commented#14 is working for me.
I am able to add all field group types.
Thank you for this patch!
Comment #16
rfsbsbI can confirm #14 works for me as well.
Comment #17
andypostComment #18
swentel commentedChecking the bot
Comment #19
providence_matt commentedI tested the patch in #14 on and it has mostly worked for me. The tabs widget, especially vertical tabs do not display correctly. The rest of the field group widgets display and function as intended.
Comment #20
adriancidRerroling the patch
Comment #21
nils.destoop commentedI tested the patch, and everything looks ok except for the horizontal tabs. They are rendering correctly, but the hidden css gets overridden by css of builder, resulting in all tabs being displayed. I'm going to check this issue and after that commit the patch.
Comment #22
corn696Fresh installation D8.8.1 new core composer template, standard profile, language german, layoutbuilder and latest dev of fieldgroup with patch 14 or 20 installed.
Activated layout builder for article.
Added groups of all types.
I am not able to find the groups under manage layout.
Comment #23
justcaldwell@Corn696 I was confused by this, too. Only after reading the whole thread a couple times did I understand that this patch only enables field groups on custom block configuration forms displayed within the Layout Builder sidebar.
Unless I am mistaken, you can't use Field Groups to group node/content fields in Layout Builder displays, unless you do something like the approach described in #11.
I tweaked to the issue title a bit to try to clarify. The description could probably use a little work, too.
Comment #25
nils.destoop commentedI modified a bit the javascript of horizontal tabs to match the modifications that core did for vertical tabs. Tabs are now working for the builder block forms. I committed the patch
Comment #26
nils.destoop commentedComment #28
murzCould anyone please share a screenshot of how this should look? Tried all the things, but couldn't mange to get the field groups visible.