Problem/Motivation

drupal-check results on commit hash: source : 188dff276ba4714676beebdb72c9afe36eee609e


 

 ------ ------------------------------------------------------------------------------- 
  Line   src/Tests/MenuAdminPerMenuNodeSave.php                                         
 ------ ------------------------------------------------------------------------------- 
  93     Call to deprecated method assertLink() of class Drupal\Tests\BrowserTestBase.  
  107    Call to deprecated method assertLink() of class Drupal\Tests\BrowserTestBase.  
  113    Call to deprecated method assertLink() of class Drupal\Tests\BrowserTestBase.  
 ------ ------------------------------------------------------------------------------- 

 [ERROR] Found 3 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#14 interdiff-3042751-11-14.txt1.39 KBjeroent
#14 3042751-14.patch4.03 KBjeroent
#11 interdiff_9-11.txt769 bytesshobhit_juyal
#11 3042751-11.patch3.92 KBshobhit_juyal
#11 patch-does-not-apply-9.png34.28 KBshobhit_juyal
#9 3042751-9.patch3.62 KBjonas139
#6 interdiff_2-6.txt417 bytesravi.shankar
#6 3042751-6.patch1.47 KBravi.shankar
#2 drupal_9_deprecated_code-3042751-2.patch1.06 KBsergiu stici

Comments

mcdwayne created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new drupal_9_deprecated_code-3042751-2.patch1.06 KB

Here is the patch, please review.

hudri’s picture

hudri
Primary language German
Location Austria
commented
Related issues: +#3126228: D9 Compatability
chris burge’s picture

chris burge commented

We should also add the 'core_version_requirement' key to menu_admin_per_menu.info.yml:

core_version_requirement: ^8 || ^9

It's not deprecated code, but it's needed for the module to be compatible with D9.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Needs work
ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
StatusFileSize
new 3042751-6.patch1.47 KB
new interdiff_2-6.txt417 bytes

Addressed comment #4.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

mrpauldriver’s picture

mrpauldriver commented

Yep, looks good. Thank you for working on this.

jonas139’s picture

jonas139 commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3042751-9.patch3.62 KB

The test should be in the 'tests' folder to run properly.
I also included the $defaultTheme and did some formatting (thanks to @JeroenT for all the remarks).

Status: Needs review » Needs work

The last submitted patch, 9: 3042751-9.patch, failed testing. View results

shobhit_juyal’s picture

shobhit_juyal commented
Status: Needs work » Needs review
StatusFileSize
new patch-does-not-apply-9.png34.28 KB
new 3042751-11.patch3.92 KB
new interdiff_9-11.txt769 bytes

Hi, @jonas139,

I tested the patch, its having the changes but does not compatible for D9. I have provided the issue's snap and the updated patch with interdiff.

Needs Review.

Thanks

Status: Needs review » Needs work

The last submitted patch, 11: 3042751-11.patch, failed testing. View results

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new 3042751-14.patch4.03 KB
new interdiff-3042751-11-14.txt1.39 KB

  • JeroenT committed 234e9dd on 8.x-1.x authored by jonas139 
    Issue #3042751 by shobhit_juyal, JeroenT, ravi.shankar, jonas139: Drupal...
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Fixed

Committed and pushed to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.