Problem/Motivation

drupal-check results on commit hash: 28fdf11154be4b13e3140e7cb810b1c708f6c18e

 ------ --------------------------------------------------------------------------------- 
  Line   src/Tests/Plugin/StyleSlideshowTest.php                                          
 ------ --------------------------------------------------------------------------------- 
  14     Class Drupal\views_slideshow\Tests\Plugin\StyleSlideshowTest extends deprecated  
         class Drupal\views\Tests\Plugin\PluginTestBase.                                  
  40     Call to method setUp() of deprecated class Drupal\views\Tests\ViewTestBase.      
 ------ --------------------------------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   views_slideshow.theme.inc                          
 ------ --------------------------------------------------- 
  54     Call to deprecated function drupal_set_message().  
  60     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 [ERROR] Found 4 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 3042681-11.patch5.49 KBmaithri shetty
#6 interdiff-4-6.txt451 bytessalah1
#6 view_slideshow_deprecated-3042681-6.patch8.87 KBsalah1
#4 interdiff2-4.txt7.73 KBlilit_ghazaryan
#4 deprecated-3042681-4.patch8.88 KBlilit_ghazaryan
#2 drupal_9_deprecated_code-3042681-2.patch3.81 KBsergiu stici

Comments

mcdwayne created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new drupal_9_deprecated_code-3042681-2.patch3.81 KB

Here is the patch, please review.

lilit_ghazaryan’s picture

lilit_ghazaryan commented
Status: Needs review » Needs work

drupal-check modules/contrib/views_slideshow/
35/35 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ---------------------------------------------------------------
Line modules/views_slideshow_cycle/views_slideshow_cycle.drush.inc
------ ---------------------------------------------------------------
163 Call to deprecated function drush_log().
176 Call to deprecated function drush_log().
181 Call to deprecated function drush_log().
187 Call to deprecated function drush_log().
------ ---------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src/Tests/Plugin/StyleSlideshowTest.php
------ ----------------------------------------------------------------------
Class Drupal\Tests\views\Functional\ViewTestBase not found and could
not be autoloaded.
------ ----------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src/ViewsSlideshowTypeInterface.php
------ ----------------------------------------------------------------------
12 Interface Drupal\views_slideshow\ViewsSlideshowTypeInterface extends
deprecated interface
Drupal\Component\Plugin\ConfigurablePluginInterface:
Drupal\Component\Plugin\ConfigurablePluginInterface is deprecated
in Drupal 8.7.0 and will be removed before Drupal 9.0.0. You should
implement
ConfigurableInterface and/or DependentPluginInterface directly as
needed. If
you implement ConfigurableInterface you may choose to implement
ConfigurablePluginInterface in Drupal 8 as well for maximum
compatibility,
however this must be removed prior to Drupal 9.
------ ----------------------------------------------------------------------

------ ------------------------------------------------------------------------
Line src/ViewsSlideshowWidgetInterface.php
------ ------------------------------------------------------------------------
12 Interface Drupal\views_slideshow\ViewsSlideshowWidgetInterface extends
deprecated interface
Drupal\Component\Plugin\ConfigurablePluginInterface:
Drupal\Component\Plugin\ConfigurablePluginInterface is deprecated
in Drupal 8.7.0 and will be removed before Drupal 9.0.0. You should
implement
ConfigurableInterface and/or DependentPluginInterface directly as
needed. If
you implement ConfigurableInterface you may choose to implement
ConfigurablePluginInterface in Drupal 8 as well for maximum
compatibility,
however this must be removed prior to Drupal 9.
------ ------------------------------------------------------------------------

------ ---------------------------------------------------------------------
Line src/ViewsSlideshowWidgetTypeInterface.php
------ ---------------------------------------------------------------------
12 Interface Drupal\views_slideshow\ViewsSlideshowWidgetTypeInterface
extends deprecated interface
Drupal\Component\Plugin\ConfigurablePluginInterface:
Drupal\Component\Plugin\ConfigurablePluginInterface is deprecated
in Drupal 8.7.0 and will be removed before Drupal 9.0.0. You should
implement
ConfigurableInterface and/or DependentPluginInterface directly as
needed. If
you implement ConfigurableInterface you may choose to implement
ConfigurablePluginInterface in Drupal 8 as well for maximum
compatibility,
however this must be removed prior to Drupal 9.
------ ---------------------------------------------------------------------

[ERROR] Found 8 errors

lilit_ghazaryan’s picture

lilit_ghazaryan commented
StatusFileSize
new deprecated-3042681-4.patch8.88 KB
new interdiff2-4.txt7.73 KB
lilit_ghazaryan’s picture

lilit_ghazaryan commented
Status: Needs work » Needs review
salah1’s picture

salah1
Location VA, U.S
commented
Status: Needs review » Needs work
StatusFileSize
new view_slideshow_deprecated-3042681-6.patch8.87 KB
new interdiff-4-6.txt451 bytes

This patch takes care of: Line 40 Call to method setUp() of deprecated class Drupal\views\Tests\ViewTestBase.

Also, applied the patch in #4 cleanly. Then re-run the drupal-check again and all the issues raised here went away except this one.
After the automated tests pass, this can be set to RTBC.

salah1’s picture

salah1
Location VA, U.S
commented
Status: Needs work » Needs review
salah1’s picture

salah1
Location VA, U.S
commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: view_slideshow_deprecated-3042681-6.patch, failed testing. View results

maithri shetty’s picture

maithri shetty commented
Assigned: Unassigned » maithri shetty
maithri shetty’s picture

maithri shetty commented
Status: Needs work » Needs review
StatusFileSize
new 3042681-11.patch5.49 KB
neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

  • Maithri Shetty authored 11e3f6c on 8.x-4.x 
    Issue #3042681 by salah1, Lilit_Ghazaryan, Maithri Shetty, Sergiu Stici...
  • Neslee Canil Pinto authored 348dc72 on 8.x-4.x
    Issue #3042681 by salah1, Lilit_Ghazaryan, Maithri Shetty, Sergiu Stici...
neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed
neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Fixed » Closed (fixed)