Drupal 9 Deprecated Code Report

I changed deprecated methods, please review.

Will you not have backwards compatibility problems removing the precations already?
Or do you expect all installations tht update this module to have the latest drupal version?

I expect the Drupal version to be larger than Drupal 8.5.x because at least Drupal\Core\TempStore\PrivateTempStoreFactory is included in the version >= 8.5.x

By using the MessengerTrait we can avoid BC issues for people extending our classes.

Thanks for this, we should start with PrivateTempStoreFactory as it already has its issue (linked).

No longer blocked.

Rerrolled and fixed a few docblocks for:

-   * @var \Drupal\views_bulk_operations\ViewsbulkOperationsViewDataInterface - Not there anymore
+   * @var \Drupal\views_bulk_operations\Service\ViewsbulkOperationsViewDataInterface - Lives here now

Also previous patch docblocks were incorrect in couple of places:

-   * @var \Drupal\user\PrivateTempStoreFactory
+   * @var \Drupal\Core\TempStore\PrivateTempStoreFactory  // what we're actually using

Self-review, when using ViewsBulkOperationsFormTrait we should use $this->messenger().

Thanks @Manuel Garcia, looks like things got committed on this branch as it doesn't apply, probably the tempstore stuff. Tagging this to be rerolled.

Tagging for DrupalCon Seattle Friday contribution sprint.
See https://github.com/mglaman/drupal-check/wiki/Drupal-9-Readiness

Slack channel #d9readiness
https://drupal.slack.com/messages/CDDD98AMN

I just tried applying #11 on 8.x-3.x after getting the latest changes, and it applies cleanly :)

I'm just at drupalcon seattle and I tried running drupal-check on patch 11, and I got the following errors:

Line src/Action/ViewsBulkOperationsActionBase.php

16 Class Drupal\views_bulk_operations\Action\ViewsBulkOperationsActionBase implements deprecated interface Drupal\Component\Plugin\ConfigurablePluginInterface.

Line src/Commands/ViewsBulkOperationsCommands.php
Class Drush\Commands\DrushCommands not found and could not be autoloaded.

+++ b/modules/views_bulk_operations_example/src/Plugin/Action/ViewsBulkOperationExampleAction.php
@@ -2,6 +2,7 @@
+use Drupal\Core\Messenger\MessengerTrait;

@@ -22,6 +23,7 @@ use Drupal\Core\Session\AccountInterface;
+  use MessengerTrait;

+++ b/src/Plugin/Action/CancelUserAction.php
@@ -2,6 +2,7 @@
+use Drupal\Core\Messenger\MessengerTrait;

@@ -21,6 +22,7 @@ use Drupal\Core\Extension\ModuleHandlerInterface;
+  use MessengerTrait;

These implementations are probably not be required. ViewsBulkOperationsActionBase extends ActionBase which extends PluginBase. PluginBase already implements MessengerTrait, so $this->messenger() should already be available.

+++ b/src/ViewsBulkOperationsBatch.php
@@ -22,10 +22,10 @@ class ViewsBulkOperationsBatch {
+    \Drupal::messenger()->addMessage($message, $type, $repeat);

I think we want this to use $this->messenger() rather than calling the service directly.

Ok, this will become a bit more tricky.
1. ConfigurablePluginInterface -> ConfigurableInterface: #3048199: Remove deprecated ConfigurablePluginInterface in favour of ConfigurableInterface
2. Class Drush\Commands\DrushCommands not found and could not be autoloaded: needs investigation
3. MessengerTrait in ViewsBulkOperationExampleAction and CancelUserAction: removed

@jerdavis, ViewsBulkOperationsBatch contains static methods, there is no $this available there.

Adding one more reference, the current array-based Batch API is not deprecated but may eventually be.

Setting this to postponed due to 3048199 but we can still commit the work already done if everything is fine with it. Starting from #11 There'll be a commit per patch that introduces something new, I'll also push a feature branch for this.

I think 2 boils down to the particular Drush version Drupal-check can find. I have Drush 10 installed in my setup and instead of complaining about a class it can not find, it says:

------ ------------------------------------------ 
  Line   views_bulk_operations.drush.inc           
 ------ ------------------------------------------ 
  174    Call to deprecated function drush_log().  
  188    Call to deprecated function drush_log().  
  198    Call to deprecated function drush_log().  
 ------ ------------------------------------------ 

I expect these to be marked as deprecated because they are in Drush 10.

As #3048199: Remove deprecated ConfigurablePluginInterface in favour of ConfigurableInterface is no longer postponed, I guess we can un-postpone this too.

I guess for this the core_version_requirement key will also need to be added, and the core version requirements should also be reflected in composer.json. However, I wonder if that should happen in 4.0, if it's decided that is to happen (see #3048199: Remove deprecated ConfigurablePluginInterface in favour of ConfigurableInterface).

Adding one more reference, the current array-based Batch API is not deprecated but may eventually be.

Looks like that issue (#2401797: Introduce a batch builder class to make the batch API easier to use only produced a different way of building the array that will be ultimately fed to batch_set(). Doesn't seem relevant all that much.

global $pager_page_array, $pager_total, $pager_total_items are deprecated and should be replaced by PageManager service methods.

Re #24, we have that handled in #3056119: Save current data of a pager now.

Can someone re-check on the latest dev and update the issue description?

@Graber issue summary updated.

Not bad, thanks :)

Thanks @jkswoods for updating the issue summary.

The deprecations on views_bulk_operations.drush.inc are because this is the legacy Drush 8 commands. I think they've already been migrated to Drush 9 (see ViewsBulkOperationsCommands) so its up to the maintainers to decide when to drop support for Drush 8. Looking at this https://docs.drush.org/en/master/install/#drupal-compatibility one could make an argument that any time would in theory be ok.

For the time being I have handled the deprecation on ViewsBulkOperationsActionBase here (see https://www.drupal.org/node/2946161)

As per #29, I think this is good to move in to RTBC.

Yes, this is actually fixed for now but there may be more deprecations in the future. We may leave it as RTBC so it doesn't dissapear from the issue queue with default filtering.

Seems like we could pick this up in follow-ups. Like #3133476: Add explicit Drush 10 support (since Drush 9 isn't supported by Drupal 9) and #3133476: Add explicit Drush 10 support (since Drush 9 isn't supported by Drupal 9). Maybe this can be marked Fixed again?

Drupal 9 is in beta now so no new issues expected. Setting to fixed.

fixed 'patch is not applicable', fix drush_log() deprecated code, updated 'drupal/core: ^9' in composer.json file, and added core_version_requirement: ^8 || ^9 for D9 supports.

@edycarreyes99, patch #13 is already committed, as per #30. So please check with latest -dev version.
Also 'closed' tickets are not supposed to be re-opened again.