Issue #3116581: Use core_version_requirement, not a version dependency on drupal:views introduces the D9-tag, but I still get an error in D9:
The 'core_version_requirement' key must be present in modules/views_bulk_operations/modules/actions_permissions/actions_permissions.info.yml

CommentFileSizeAuthor
#15 interdiff-12-15.txt300 bytespiggito
#15 vbo-3131516-15.patch1.47 KBpiggito
#12 vbo-3131516-12.patch1.17 KBwrd
#6 vbo-3131516-6.patch1.15 KBwrd
#4 vbo-3131516-4.patch1.3 KBwrd
#2 views_bulk_operations-3131516-2.patch570 byteskarishmaamin

Comments

johnv created an issue. See original summary.

karishmaamin’s picture

karishmaamin commented
Status: Active » Needs review
StatusFileSize
new views_bulk_operations-3131516-2.patch570 bytes

Added core_version_requirement in actions_permissions.info.yml, please review

johnv’s picture

johnv
Primary language Dutch
commented
Status: Needs review » Needs work

I guess this is needed for all submodules, so also: views_bulk_operations_example.
Afterwards, we need to test for deprecated code (in a separate (already existing?) issue.

wrd’s picture

wrd commented
StatusFileSize
new vbo-3131516-4.patch1.3 KB

Same, but also for the example module.

johnv’s picture

johnv
Primary language Dutch
commented

The "# Information added by" lines should not be in the patch.

wrd’s picture

wrd commented
StatusFileSize
new vbo-3131516-6.patch1.15 KB

Whoops! This should clean that up.

johnv’s picture

johnv
Primary language Dutch
commented
Status: Needs work » Reviewed & tested by the community

better.

johnv’s picture

johnv
Primary language Dutch
commented
Status: Reviewed & tested by the community » Needs work

Not OK:
Drupal\Core\Extension\InfoParserException: The 'core_version_requirement' constraint (^8.8 || ^9) requires the 'core' key not be set in modules/views_bulk_operations/modules/actions_permissions/actions_permissions.info.yml
Drupal\Core\Extension\InfoParserException: The 'core_version_requirement' constraint (^8.8 || ^9) requires the 'core' key not be set in modules/views_bulk_operations/modules/views_bulk_operations_example/views_bulk_operations_example.info.yml

IMO, a crappy specification.
So, this is OK: 

core: 8.x
core_version_requirement: ^8 || ^9

and this is not: 

core: 8.x
core_version_requirement: ^8.8 || ^9
wrd’s picture

wrd commented

My guess is that ^8.8 was specified for good reason? So we probably want to remove the "core" key, rather than changing "^8.8" to "^8"?

johnv’s picture

johnv
Primary language Dutch
commented

I think so, too.

graber’s picture

graber commented

Confirming #9.

wrd’s picture

wrd commented
StatusFileSize
new vbo-3131516-12.patch1.17 KB

OK, this one removes the old "core" keys.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Category: Bug report » Task
Status: Needs work » Needs review

Adding some test runs to see how things fare. We might need to commit this patch, then re-test again.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work

Also, need to add core version support to composer.json for ^9.0

piggito’s picture

piggito commented
Status: Needs work » Needs review
StatusFileSize
new vbo-3131516-15.patch1.47 KB
new interdiff-12-15.txt300 bytes

Updated composer.json to support drupal 9

piggito’s picture

piggito commented

Drupal 9 test fails cause we need changes committed into dev for composer to resolve dependencies so I guess it can be ignored.

  • Graber committed beb2027 on 8.x-3.x authored by piggito 
    Issue #3131516 by wrd, piggito, karishmaamin: Use...
graber’s picture

graber commented
Status: Needs review » Fixed

Reviewed and pushed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.