Problem/Motivation

drupal-check results on commit hash: b3c550ee3830428317365af1b70a9b49a20a9cab

 ------ ---------------------------------------------- 
  Line   better_exposed_filters.theme                  
 ------ ---------------------------------------------- 
  52     Call to deprecated function drupal_render().  
  177    Call to deprecated function drupal_render().  
  481    Call to deprecated function drupal_render().  
 ------ ---------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------- 
  Line   tests/src/Unit/BetterExposedFiltersTest.php                                                       
 ------ -------------------------------------------------------------------------------------------------- 
         Class Drupal\better_exposed_filters\Tests\BetterExposedFiltersTest was not found while trying to  
         analyse it - autoloading is probably not configured properly.                                     
 ------ --------------------------------------------------------------------------------------------------

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 better_exposed_filters-drupal-9-code-report-3042603-6.patch433 bytestomvanetten
#3 better_exposed_filters-3042603-3.patch1.23 KBjigish.addweb

Comments

oheller created an issue. See original summary.

jeremyr’s picture

jeremyr commented
Related issues: +#2773457: drupal_render is going to be deprecated so it has to be removed

Looks like we have related issue where someone has created a patch for at least the drupal_render() function.

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new better_exposed_filters-3042603-3.patch1.23 KB

@oheller, Kindly review the attached patch that helps you for the requirement mentioned above. Feel free to share your views on the same after using it.

Thanks!

jigish.addweb’s picture

jigish.addweb commented
Status: Active » Needs review
tomvanetten’s picture

tomvanetten commented
Assigned: Unassigned » tomvanetten
Status: Needs review » Needs work

no deprecation anymore, only a sidenote that we can make use of the import use Drupal to remove the 3 leading slashed, but for now not relevant

Still needs work as the info.yml does not contain the requirement;

tomvanetten’s picture

tomvanetten commented
Version: 8.x-3.x-dev » 8.x-4.x-dev
StatusFileSize
new better_exposed_filters-drupal-9-code-report-3042603-6.patch433 bytes

targeted newest dev branch.

tomvanetten’s picture

tomvanetten commented
Status: Needs work » Needs review

Better Exposed Filters, 8.x-4.0-dev
Scanned on Thu, 10/31/2019 - 23:32

FILE: better_exposed_filters.info.yml

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
0 Add core_version_requirement: ^8 || ^9 to
better_exposed_filters.info.yml to designate that the module
is compatible with Drupal 9. See
https://www.drupal.org/node/3070687.
--------------------------------------------------------------------------------

tomvanetten’s picture

tomvanetten commented
Assigned: tomvanetten » Unassigned

  • tomvanetten authored 8707706 on 8.x-4.x 
    Issue #3042603 by tomvanetten, jigish.addweb: Drupal 9 Deprecated Code...
etroid’s picture

etroid commented

Thanks for the patch, I've applied this to the latest 8.x-4.x branch

etroid’s picture

etroid commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.