Problem/Motivation

According to https://api.drupal.org/api/drupal/core!includes!common.inc/function/drup... drupal_render is deprecated. better_exposed_filters still uses drupal_render in its .theme file.

Proposed resolution

change it to \Drupal::service('renderer')->render($elements, $is_recursive_call);

Remaining tasks

Create a patch.
Review.

User interface changes

API changes

CommentFileSizeAuthor
#4 drupal_render-2773457.patch1.23 KBjeremyr
drupal_render-is-going-to-be-deprecated-so-it-has-to-be-removed.patch1.41 KBkapil.ropalekar

Comments

kapil.ropalekar created an issue. See original summary.

mikeker’s picture

mikeker commented
Status: Needs review » Needs work

Thank you for the patch. True, it has been deprecated, but does not need to be removed until Drupal 9.x. If we are going to clean this up in D8, I would prefer to inject the dependency on the renderer service instead of calling it directly.

mikeker’s picture

mikeker commented
Status: Needs work » Postponed

I'm marking this as postponed to 9.x unless there is a patch that will inject the renderer.

Thank you for the patch, @kapil.ropalekar, but at this point I have to focus my attention on 8.x issues.

jeremyr’s picture

jeremyr commented
Status: Postponed » Needs review
StatusFileSize
new drupal_render-2773457.patch1.23 KB

Picking this one back up. Rerolled the patch against current dev with a minor change.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs review » Closed (won't fix)

We are trying to deprecate 8.x-3.x, can you please check whether this still exists in 8.x-4.x/8.x-5.x branch.