Cater for workbench_moderation_actions module removing node_publish action

Yes it might cause a fatal error, but this is a core action, so Scheduler should be able to rely on it being there. Is it really OK for another contrib module to delete a core action? How many other modules might also suffer the same experience as Scheduler?

Have you raised this on the Workbench Moderation Actions queue to see what they say about it?

Rerolling patch against 8.x-1.1

Thanks @jonnyhocks for the re-roll. I presume you are using Scheduler and Workbench Moderation Actions sucessfully with this patch? Interesting that WBMA has just 1,400 installs but Workbench Modertation is used by 5,600 8.x sites. So three quarters of the users have not discovered the problem stated on the project page "If you use Workbench Moderation, you'll soon find that Drupal core's 'Publish content' and 'Unpublish content' actions don't work"

Anyway, if you and @nicrodgers (who I notice is the maintainer of WBMA) say that this patch fixes the problem for you, then I will commit it, as it seems safe enough and will have no impact for non-WBMA users (apart from the overhead of checking if that module is installed).

Jonathan

Hello, @all I have shared this patch it is working for me. hope it will work for you guys also

Hi @omrmankar, thanks for your patch but that is not exactly what this issue is about. We have the Scheduler Content Moderation Intergration module to cover all of those tasks, so you should use that.

@nicrodgers and @jonnyhocks, I have re-rolled patch #4 for the latest -dev. Also I noticed that Workbench Moderation Actions also removes the core 'node_unpublish_action' action during installation:

/**
 * Implements hook_install().
 */
function workbench_moderation_actions_install() {
  // Remove the publish/unpublished actions.
  if ($action = Action::load('node_publish_action')) {
    $action->delete();
  }
  if ($action = Action::load('node_unpublish_action')) {
    $action->delete();
  }

So I think if Scheduler is catering for one it should cater for both, and replace 'node_unpublish_action' with 'state_change__node__archived'. Patch #7 does this. Please could you test this if possible? I will be making a new Scheduler release with the next two days, so if you can test it soon that would be great. Thank you.

Typo. That's the beauty of testing.

Thank you nicrodgers, that is really helpful. For right now, I think I will commit this patch, as it caters for the sites which have the default Workbench Moderation actions and are using WBMA. Then I can make the 1.3 release.

Your idea of Scheduler configuration options for the actions is good, and can be discussed in a follow-up issue. Would you like to raise that issue?

Committed and fixed. Thank you @nicrodgers and @jonnyhocks.