Problem/Motivation

The module does a lot of selecting and writing to/from its schema but has no indexes.

https://cgit.drupalcode.org/purge_queuer_url/tree/src/TrafficRegistry.ph...

Proposed resolution

Add some indexes.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 interdiff.txt2.12 KBrosk0
#6 purge_queuer_url-3037842-6.patch2.32 KBrosk0
#4 image (5).png38.55 KBalexj12

Issue fork purge_queuer_url-3037842

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

Alexj12 made their first commit to this issue’s fork.

Alexj12 opened merge request !5

alexj12’s picture

alexj12 commented
Status: Active » Needs review
StatusFileSize
new image (5).png38.55 KB

I've created a new MR which adds an index to the primary column that requires it. Making this change resolved purge_queuer_url update and delete functions being our two highest time consuming database calls and dropped them off the radar completely.

It makes a significant improvement.

DB call time

kolin’s picture

kolin commented
Status: Needs review » Reviewed & tested by the community

I've tested this and it works as expected.

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new purge_queuer_url-3037842-6.patch2.32 KB
new interdiff.txt2.12 KB

Added index to the purge_queuer_url_tag table as well. Also added update path.

alexj12’s picture

alexj12 commented
Status: Needs review » Reviewed & tested by the community

Reviewed and tested as I had actually added an index to the tag table previously but hadn't updated the patch! Thanks!

ericgsmith made their first commit to this issue’s fork.

  • ericgsmith committed 93a62041 on 8.x-1.x authored by Alexj12 
    Issue #3037842: Add indexes to the schema for performance sake
ericgsmith’s picture

ericgsmith commented
Status: Reviewed & tested by the community » Fixed

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.