Problem/Motivation

It's impossible to activate tour with really small viewport width (below 16.5em) because the tour toolbar tab is unclickable (floats below the first toolbar tab).

Proposed resolution

Float the item only if the toolbar is oriented OR when another toolbar tabs are floated as well.

Remaining tasks

Patch.

User interface changes

Tour toolbar tab will be similar to other tabs if viewport width is less than 16.5em.

API changes

Nothing.

Data model changes

Nothing.

Screenshot before patch

Tour tab floats below an another toolbar tab

CommentFileSizeAuthor
#5 Screen Shot 2019-12-02 at 22.17.45.png299.99 KBlauriii
#3 3037260-after2.png69.27 KBcindytwilliams
#3 3037260-after.png47.53 KBcindytwilliams
#2 tour-toolbar_tab_fix-3037260-2.patch2.56 KBhuzooka
#2 tour-tab-unoriented-after.png40.21 KBhuzooka
tour-tab-unoriented-before.png63.13 KBhuzooka

Comments

huzooka created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: huzooka » Unassigned
Status: Active » Needs review
StatusFileSize
new tour-tab-unoriented-after.png40.21 KB
new tour-toolbar_tab_fix-3037260-2.patch2.56 KB

After:

Fixed tour tab placement

cindytwilliams’s picture

cindytwilliams commented
Version: 8.6.x-dev » 8.8.x-dev
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3037260-after.png47.53 KB
new 3037260-after2.png69.27 KB

Patch #2 applied cleanly, and caused the tour toolbar tab to be displayed vertically amongst the other tabs when the viewport width is less than 16.5em, thereby making it clickable to activate the tour. Screenshots attached. Marking RTBC.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs issue summary update
StatusFileSize
new Screen Shot 2019-12-02 at 22.17.45.png299.99 KB

This also affects "Edit" toolbar item which is added in contextual_toolbar(). Let's make sure that it's rendered correctly as well.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Needs work » Needs review
Related issues: +#3035791: Contextual toolbar item is unclickable on really small viewport width (below 16.5em), +#3037249: Settings tray's contextual toolbar item is unclickable on really small viewport width (below 16.5em)

Re #5, @lauriii:

I already posted an another issue for contextual (and even for Settings tray):

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Postponed (maintainer needs more info)
Issue tags: +Bug Smash Initiative

Tested at various widths in mobile and I was not able to replicate this issue.

Can you provide an updated issue summary and testing steps for where you are seeing this? Core version, admin theme, exact page, etc.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Since this was moved to PNMI 4 months ago, which is past the 3 month threshold going to close out as outdated.

If still an issue please reopen with an updated issue summary and testing steps please

Thank you!