Problem/Motivation

It's impossible to enter edit mode with really small viewport width (below 16.5em) because the altered contextual toolbar tab item is unclickable (floats below the first toolbar tab).

Proposed resolution

Float the item only if the toolbar is oriented OR when another toolbar tabs are floated as well.

Remaining tasks

Patch.

User interface changes

Contextual toolbar tab will be similar to other tabs if viewport width is less than 16.5em.

API changes

Nothing.

Data model changes

Nothing.

CommentFileSizeAuthor
#13 Settings tray toolbar.png38.93 KBdeepalij
#11 interdiff_10-11.txt382 bytespooja saraah
#11 3037249-11.patch1.16 KBpooja saraah
#10 3037249-10.patch1.29 KBameymudras
#3 settings_tray-toolbar_item_fix-3037249-3.patch2.34 KBhuzooka
#3 settings-tray-unoriented-after.png45.23 KBhuzooka
#2 settings-tray-unoriented-before.png73.65 KBhuzooka

Comments

huzooka created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
StatusFileSize
new settings-tray-unoriented-before.png73.65 KB

'Before' screenshot:

Unoriented settings tray bar is unclickable

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: huzooka » Unassigned
Status: Active » Needs review
StatusFileSize
new settings-tray-unoriented-after.png45.23 KB
new settings_tray-toolbar_item_fix-3037249-3.patch2.34 KB

The attached patch fixes the issue only if #3035791: Contextual toolbar item is unclickable on really small viewport width (below 16.5em) #10 is applied as well.

'After':

Settings tray toolbar tab after applying fixes

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Needs work
Issue tags: +Bug Smash Initiative, +Needs tests

This came up as the daily triage target for the Bug Smash Initiative.

I can reproduce this, so seems valid and the patch seems to do the trick, my CSS foo is limited so not sure if it’s ok from that end.

But I'm wondering if this needs an automated test. We can test for things being clickable, so I think we can test it, so we probably should test it? I think.....

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

ameymudras’s picture

ameymudras commented
Version: 9.4.x-dev » 9.5.x-dev
Status: Needs work » Needs review
StatusFileSize
new 3037249-10.patch1.29 KB

Re rolling the patch to 9.5.x and removing theme specific styles

pooja saraah’s picture

pooja saraah commented
StatusFileSize
new 3037249-11.patch1.16 KB
new interdiff_10-11.txt382 bytes

Fixed failed commands on #10
Attached patch against Drupal 9.5.x

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

deepalij’s picture

deepalij commented
StatusFileSize
new Settings tray toolbar.png38.93 KB

Applied patch #11 on Drupal 10.1.x-dev version.
The patch applied cleanly.

The settings tray's contextual toolbar item is clickable and the orientation also looks fine on the small viewport width
Refer to the attached screenshot
after

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

This issue is being reviewed by the kind folks in Slack, #need-reveiw-queue. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge require as a guide.

FYI tried to replicate on D10 but could not.

But moving back to NW for tests.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Postponed

The Settings Tray Module was approved for removal in #3576315: [policy, no patch] Move Settings Tray to a contributed project.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3576667: [meta] Tasks to deprecate Settings Tray and the removal work in #3581818: [meta] Tasks to remove Settings Tray module.

Settings Tray will be moved to a contributed project before Drupal 12.0.0 is released.