Refactor usage of button component on links

Working on this one for drupalcon seattle sprint unless objections!

After reviewing all Claro's templates and alter_hooks I could find no inappropriate uses of anchor links as buttons. I believe this issue is ready to be closed.

@lauriii How should we proceed with this one?
Reviewing this in detail, they are so many cases where the visual appearance is a button but the element is an anchor.

/admin/content
/admin/people
/admin/structure/block
/admin/structure/comment
/admin/structure/types

Here's a first crack at this. This addresses all the scenarios mentioned in #7

Local Actions
Place a block on Blocks UI (including the modal that appears after clicking "Place block")
Cancel button on entity delete form
Delete button on entity edit form

Also addressed most of the items listed in #9 (will detail what didn't happen)

/admin/content
/admin/people
/admin/structure/block
/admin/structure/comment
/admin/structure/types

Parts that arent ideal yet

• Converting the cancel/delete buttons to links results in poor alignment with adjacent elements. Not sure if addressing that is in scope for this issue or if it should get a followup so design can properly weigh in
  
• The Show all/Hide lower priority columns toggle found on /admin/people (among other places) uses tableresponsive.js
  it is a button element that is styled to look like a link, and not sure how to best change that since the markup is added in JS.
  
• Links that had the .button--primary class such as "Install theme" and "Add field" no longer look as "significant" as they should as links. I changed the font weight to bold, but there are probably some additional design choices necessary to ensure these continue to get their deserved emphasis.
  

  

• Based on the modules source code, it looked like there may be an instance or two of this in the Workspaces module. Having never used this module, I had no idea how to access the areas where this might appear.

It occurred to me after posting the patch that some of these elements will behave differently in no-js situations. There are instances where something that functions as a button with Javascript enabled (such as triggering a modal) will be a link when Javascript isn't enabled. This should be taken into account when work continues on this patch. I'm tempted to make these changes right now, but I think it would be best to get another set of eyes on #11 to determine if the overall approach seems solid before expanding on it.

Converting the cancel/delete buttons to links results in poor alignment with adjacent elements.

The cancel/delete buttons should start using the styles for the Action Link new component. That would handle the alignment problem. The previous step for the delete icon though would be to define which icon should be used on each Action Link. I just opened this to handle that: #3074893: Change the delete button to use an action link, but feel free to close as duplicated if you think it can be solved here.

Links that had the .button--primary class such as "Install theme" and "Add field" no longer look as "significant" as they should as links.

#3036742: CTA - Call to action component will ideally solve this, and it's a stable blocker. If this ones moves forward we will define CTA as beta blocker.

Adding here the beta blocker tag, specially because this is needed for #3074893: Change the delete button to use an action link.

I've prepared a version for the button in tables/list to show/hide the columns: https://www.figma.com/file/OqWgzAluHtsOd5uwm1lubFeH/Drupal-Design-system...

I'm concerned about this being the correct approach for this specific element though: I've used the action link style because it takes less visual relevance, but it's a button, not a link. Does anyone knows if this could be a problem on an accessibility point of view?

Removing beta blocker because #3036732: Action link component is already in.

#22 Please review the patch

No need for reroll against #23

Also next time @sakthivel-m please provide an interdiff

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Patch #23, no longer applies to 10.1.x. Here I have attached the re-rolled patch for 10.1.x. please review

re-rolled patch missed link.css file. Added same and attached interdiff.

The Claro theme was approved for removal in #3576460: [policy, no patch] Deprecate and remove Claro.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3576668: [meta] Tasks to deprecate Claro and the removal work in #3584638: [meta] Tasks to remove the Claro theme.

Claro has moved to contrib