When I try to add the VBO field to a form in 8.7 I get this error in the AJAX response:

Access level to Drupal\views_bulk_operations\Plugin\views\field\ViewsBulkOperationsBulkForm::isConfigurable() must be public (as in class Drupal\Component\Plugin\PluginBase) in views_bulk_operations/src/Plugin/views/field/ViewsBulkOperationsBulkForm.php on line 32

CommentFileSizeAuthor
#7 views_bulk_operations-3030554-7.patch1.75 KBgraber
#2 views_bulk_operations-n3030554-2.patch656 bytesdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new views_bulk_operations-n3030554-2.patch656 bytes

This change allowed the field to be added.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: ViewsBulkOperationsBulkForm::isConfigurable() must be public » ViewsBulkOperationsBulkForm::isConfigurable() compatibility for 8.7

The patch then results in this error when you open the page with the view:

Warning: Declaration of Drupal\views_bulk_operations\Plugin\views\field\ViewsBulkOperationsBulkForm::isConfigurable($action) should be compatible with Drupal\Component\Plugin\PluginBase::isConfigurable() in include() (line 32 of modules/contrib/views_bulk_operations/src/Plugin/views/field/ViewsBulkOperationsBulkForm.php).

Here's the docs page for the method: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Plug...

It seems that there was an API change in 8.7: https://www.drupal.org/node/2946161

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: ViewsBulkOperationsBulkForm::isConfigurable() compatibility for 8.7 » Fix 8.7 compatibility problems in ViewsBulkOperationsBulkForm
Issue summary: View changes
Status: Needs review » Needs work

Clearly this needs further work.

graber’s picture

graber commented

This function is for internal use. We can just rename it to isActionConfigurable. if the isConfigurable() method is required and not implemented in parent classes, it can be implemented separately.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

@Graber that's probably the best solution to rename it, too bad for the method name collision.

graber’s picture

graber commented
Status: Needs work » Needs review
StatusFileSize
new views_bulk_operations-3030554-7.patch1.75 KB

  • Graber committed 0286d2b on 8.x-2.x 
    Issue #3030554 by DamienMcKenna, Graber, joelpittet: Fix 8.7...
graber’s picture

graber commented
Status: Needs review » Fixed

Right. Thanks guys!

  • Graber committed ae4ce91 on 8.x-3.x 
    Applied fixes for #3034023, #3030554 and #3000714.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Is there a chance you could release a new 2.x version of the module with this change, as it will assist those beta-testing 8.7

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Parent issue: » #3044027: [meta] 8.7.0 beta testing
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Ignore me, the 2.x branch commit was before the last release - thanks!