[meta] 8.7.0 beta testing

Not sure what is a best place for this question so asking here: at the moment table has one line for a person and testing outcome, but what if we have multiple projects that we are going to test update process against? How do we report ? For me it make sense to report against each individual project and have a separate line the tracking table.

I think one per project would make sense

Another reported issue #3044676: Fatal error in ContentEntityBase after updating to 8.7.0-beta1

To me that seems like an internal management strategy, I'm not sure whether it matters to core development whether two bugs come from different installations. That can be useful info for debugging purposes and should be shared in the individual issues, but I'm not sure why it matters for tracking purposes. Can you elaborate?

I think it adds more weight if for example @RoSk0 tested 5 sites and there were no issues. If he only had one row in the sheet, then we don't capture those metrics.

Say for my employer (PreviousNext) we'd be testing about 10 sites, so that would be the same case

Thanks @larowlan, this was exactly what I was referring to.

Meanwhile, tested one project and it went fine, table updated.

Testing of Thunder on Drupal 8.7.0-beta1 found #3044894: \Drupal\fb_instant_articles\Plugin\views\row\FiaFields::__construct() broken on Drupal 8.7.x. It's in contrib and I'm not sure that we'd fix core for it (or even can because this is a constructor change and therefore no BC).

Here's a summary of the things Thunder has had to deal with to support Drupal 8.7.0-beta1.

• 1 contrib issue - see #11
• Admin theme z-index changes need resolving
• Config schema changes make running tests on 8.6.x and 8.7.x with config schema checking impossible
• NodeForm changes in core prompted us to refactor to a form alter and decouple from the NodeForm

None of these issues are covered by Drupal's BC promise so all's good but it is worth pointing them out. See https://github.com/BurdaMagazinOrg/thunder-distribution/pull/641 for all the changes.

We have successfully updated from Thunder 2.0 built on Drupal 8.3 to Thunder 2.x on 8.7.0-beta1

Summary of issues on one of the projects I maintain

- #3030554: Fix 8.7 compatibility problems in ViewsBulkOperationsBulkForm had to update to 2.5 version of views_bulk_operations
- Had to run updates twice (drush updb) as first time failed between the updates and post-updates with [error] Malformed backend packet and from the menu_link_post_content_post_update_make_menu_link_content_revisionableBatch process did not return a result array. Returned: booleanbut second time ran through
- some changes to custom kernel tests to include setting up the user entity and adding 'user' to $modules
- some changes to constructor type-hinting that previously hinted on \Egulias\EmailValidator\EmailValidatorInterface to typehint on \Drupal\Component\Utility\EmailValidatorInterface

Summary of issues in second project

- constructor changes on plugins that extended from \Drupal\views\Plugin\views\filter\StringFilter
- signature change on BrowserTestBase::createUser

-  public function createUser(array $permissions = array(), $name = NULL, $admin = FALSE) {
+  public function createUser(array $permissions = array(), $name = NULL, $admin = FALSE, array $values = []) {

- test failing on Drupal\Core\Entity\EntityStorageException: Update existing 'user' entity while changing the ID is not supported. which was coming from teardown, some minor changes to teardown in custom tests resolved that

Update from project three:

- as above signature change on BrowserTestBase::createUser

-  public function createUser(array $permissions = array(), $name = NULL, $admin = FALSE) {
+  public function createUser(array $permissions = array(), $name = NULL, $admin = FALSE, array $values = []) {

- some changes to custom kernel tests to include setting up the user entity and adding 'user' to $modules

yeah, beta2 sorry

Testing from fourth site still in progress, not crediting customer as came out of PNX time

- Found #3039955: Ensure EntityKernelTestBase can use UserCreationTrait::setUpCurrentUser() is still not right, wrote failing/passing test to demonstrate the issue
- Found that there was missing entity-type definitions when injected into as the last installed entity type was missing custom annotations (under additional) that had been added post install - wrote an update hook to set those. Most likely from #3038707: The entity type definition is out of sync between SqlContentEntityStorage and SqlContentEntityStorageSchema during field storage CRUD operations
- Update simple_sitemap Argument 1 passed to Drupal\simple_sitemap\EntityHelper::getEntityInstanceBundleName() must be an instance of Drupal\Core\Entity\Entity, instance of Drupal\node\Entity\Node Node now extends from EntityBase

I upgraded a site with a custom content entity and ran into the following error:

Uncaught PHP Exception Drupal\\Core\\Entity\\Query\\QueryException: "No revision table for digital_asset, invalid query." at /app/web/core/lib/Drupal/Core/Entity/Query/Sql/Query.php line 98

In the past when updating to 8.5 `revision_table = "digital_asset_revision",` was added to the entity class's annotations so as to resolve an error that occurred post upgraded to 8.5,
Having added this new annotation `drush entity-updates` was never run, so the stored definition did not match that in code.

Now, due to Support for automatic entity updates has been removed, the stored entity_type definition `digital_asset.entity_type` does not include the revision_table field and so triggers the above error.

I was able to resolve this with an update hook to specifically set the revision_table value in the key value store, like so
```
$collection = \Drupal::keyValue('entity.definitions.installed');
$entity_type = $collection->get( 'digital_asset.entity_type');
$entity_type->set('revision_table','digital_asset_revision');
$collection->set('digital_asset.entity_type', $entity_type);
```

I tested one site and found one issue #3044682: Permission denied creating /tmp/twig However, I was not able to reproduce it.

No other issues.