Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
9 Jan 2019 at 14:36 UTC
Updated:
27 Apr 2019 at 12:04 UTC
Jump to comment: Most recent
Comments
Comment #2
manish34jain commentedHello Rahul,
Checked and fixed issues using pareview.sh
FILE: ...ite1101/web/vendor/drupal/pareviewsh/pareview_temp/hypothesis.module -------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES -------------------------------------------------------------------------- 31 | WARNING | Do not use drupal_add_js() in hook_page_build(), use | | #attached for CSS and JS on the $page render array | | instead 32 | WARNING | Do not use drupal_add_js() in hook_page_build(), use | | #attached for CSS and JS on the $page render array | | instead 36 | WARNING | Do not use drupal_add_js() in hook_page_build(), use | | #attached for CSS and JS on the $page render array | | instead --------------------------------------------------------------------------Comment #3
avpadernoIf you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.
I am closing this application due to lack of activity.
Comment #4
rahul.shindeNow all the issues are fixed. Here is the PAReview link. https://pareview.sh/pareview/https-git.drupal.org-project-hypothesis.git
Thanks, @manish34jain.
@kiamlaluno, sorry for this delay. I'll not let this happen again.
Comment #5
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.